From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS
Date: Sun, 15 Dec 2019 08:56:16 +0100 [thread overview]
Message-ID: <875ziif2e7.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191214215428.75264bb3@windsurf.home> (Thomas Petazzoni's message of "Sat, 14 Dec 2019 21:54:28 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Sat, 14 Dec 2019 18:10:23 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> Since commit 1745fcde740057951dcc5429f3bfabd103b764a1,
>> python-subprocess32 fails to build because it runs configure with
>> incorrect arguments so add a PYTHON_SUBPROCESS32_CONFIGURE_CMDS
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/dcf944129392ee6cacc106e096d8d3adfa4447bb
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> When seeing this, I was a bit "meh, how did it work before?". So I
> built python-subprocess32 with 1745fcde740057951dcc5429f3bfabd103b764a1
> reverted. What happens is that the ./configure script is executed, with
> no arguments at all, and no CC variable is passed. So it happily uses
> the host compiler, does a bunch of tests with it, and then uses the
> resulting config.h file to build some target library. This is obviously
> completely bogus!
> With 1745fcde740057951dcc5429f3bfabd103b764a1, we now pass
> CC=cross-compiler, so ./configure doesn't work because it uses a
> cross-compiler, but no --host= value is passed, leading to the build
> failure.
> So 1745fcde740057951dcc5429f3bfabd103b764a1 really uncovered a real bug
> in the python-subprocess32 packaging, which your patch fixes.
Wow, (part of) this info would have been great to add to the commit
message.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-12-15 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 17:10 [Buildroot] [PATCH 1/1] package/python-subprocess32: add PYTHON_SUBPROCESS32_CONFIGURE_CMDS Fabrice Fontaine
2019-12-14 20:54 ` Thomas Petazzoni
2019-12-15 7:56 ` Peter Korsgaard [this message]
2019-12-23 9:06 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ziif2e7.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.