From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Doug Gale <doug16k@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: Lockup with --accel tcg,thread=single
Date: Tue, 01 Oct 2019 16:28:03 +0100 [thread overview]
Message-ID: <875zl8lc3g.fsf@linaro.org> (raw)
In-Reply-To: <e84bb7eb-07df-1c84-c4d7-285c40436751@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 01/10/19 10:42, Alex Bennée wrote:
>>
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> On 30/09/19 21:20, Alex Bennée wrote:
>>>> Does seem to imply the vCPU CPUState is where the queue is. That's not
>>>> to say there shouldn't be a single work queue for thread=single.
>>>
>>> Indeed it doesn't. I confused this with commit a8efa60633 ("cpus: run
>>> work items for all vCPUs if single-threaded", 2018-11-27).
>>>
>>> Are you going to make a patch to have a single work queue, or should
>>> I?
>>
>> What's the neatest way to do it? Are you thinking just special case
>> queue_work_on_cpu to special case first_cpu when mttcg is not enabled?
>
> Yes, I cannot think of anything better.
And I am immediately stymied by the fact that cpus-common is a common
blob so can't have differentiation for SOFTMMU cases in it.
Did you have a look at:
Date: Mon, 30 Sep 2019 17:38:15 +0100
Message-ID: <87h84tloy0.fsf@linaro.org>
Is that too ugly?
>
> Paolo
--
Alex Bennée
next prev parent reply other threads:[~2019-10-01 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 13:15 Lockup with --accel tcg,thread=single Doug Gale
2019-09-30 15:37 ` Peter Maydell
2019-09-30 16:38 ` Alex Bennée
2019-09-30 17:47 ` Paolo Bonzini
2019-09-30 19:20 ` Alex Bennée
2019-09-30 20:40 ` Paolo Bonzini
2019-10-01 8:42 ` Alex Bennée
2019-10-01 9:16 ` Paolo Bonzini
2019-10-01 15:28 ` Alex Bennée [this message]
2019-10-01 12:10 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2019-09-30 13:12 Doug Gale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zl8lc3g.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=doug16k@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.