All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Jerez <currojerez@riseup.net>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/9] drm/i2c/sil164: use drm_debug_enabled() to check for debug categories
Date: Tue, 24 Sep 2019 12:29:22 -0700	[thread overview]
Message-ID: <875zlhwl0t.fsf@riseup.net> (raw)
In-Reply-To: <f6f65ca7e27e949533e8cd1f43c61ecac73c658e.1569329774.git.jani.nikula@intel.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1008 bytes --]

Jani Nikula <jani.nikula@intel.com> writes:

> Allow better abstraction of the drm_debug global variable in the
> future. No functional changes.
>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
> index 8bcf0d199145..a839f78a4c8a 100644
> --- a/drivers/gpu/drm/i2c/sil164_drv.c
> +++ b/drivers/gpu/drm/i2c/sil164_drv.c
> @@ -44,7 +44,7 @@ struct sil164_priv {
>  	((struct sil164_priv *)to_encoder_slave(x)->slave_priv)
>  
>  #define sil164_dbg(client, format, ...) do {				\
> -		if (drm_debug & DRM_UT_KMS)				\
> +		if (drm_debug_enabled(DRM_UT_KMS))			\
>  			dev_printk(KERN_DEBUG, &client->dev,		\
>  				   "%s: " format, __func__, ## __VA_ARGS__); \
>  	} while (0)
> -- 
> 2.20.1

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-09-24 19:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 12:58 [PATCH v2 0/9] drm/print: add and use drm_debug_enabled() Jani Nikula
2019-09-24 12:58 ` Jani Nikula
2019-09-24 12:58 ` [PATCH v2 1/9] drm/print: move drm_debug variable to drm_print.[ch] Jani Nikula
2019-09-24 17:45   ` Alex Deucher
2019-09-24 12:58 ` [PATCH v2 2/9] drm/print: add drm_debug_enabled() Jani Nikula
2019-09-24 17:45   ` Alex Deucher
2019-10-01 14:06   ` [PATCH v3] " Jani Nikula
2019-10-01 15:02     ` Eric Engestrom
2019-09-24 12:58 ` [PATCH v2 3/9] drm/etnaviv: use drm_debug_enabled() to check for debug categories Jani Nikula
2019-09-24 12:59 ` [PATCH v2 4/9] drm/i2c/sil164: " Jani Nikula
2019-09-24 19:29   ` Francisco Jerez [this message]
2019-09-24 12:59 ` [PATCH v2 5/9] drm/i915: " Jani Nikula
2019-09-24 12:59 ` [PATCH v2 6/9] drm/msm: " Jani Nikula
2019-09-24 12:59   ` Jani Nikula
2019-09-24 12:59 ` [PATCH v2 7/9] drm/nouveau: " Jani Nikula
2019-09-24 12:59 ` [PATCH v2 8/9] drm/amdgpu: " Jani Nikula
2019-09-24 17:44   ` Alex Deucher
2019-09-24 12:59 ` [PATCH v2 9/9] drm/print: rename drm_debug to __drm_debug to discourage use Jani Nikula
2019-09-24 17:46   ` Alex Deucher
2019-09-24 14:15 ` ✓ Fi.CI.BAT: success for drm/print: add and use drm_debug_enabled() (rev2) Patchwork
2019-09-25  2:39 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-09-26  7:48 ` [PATCH v2 0/9] drm/print: add and use drm_debug_enabled() Eric Engestrom
2019-09-26  7:48   ` Eric Engestrom
     [not found]   ` <20190926074814.rdzxjmut6izqf4d5-op+oiCINJLTt9jDmeYuA0g@public.gmane.org>
2019-10-01 11:03     ` Jani Nikula
2019-10-01 11:03       ` Jani Nikula
     [not found]       ` <875zl8d8x0.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-10-01 12:34         ` Eric Engestrom
2019-10-01 12:34           ` Eric Engestrom
     [not found]           ` <20191001123444.xtp7wpickwjus4m2-op+oiCINJLTt9jDmeYuA0g@public.gmane.org>
2019-10-01 14:08             ` Jani Nikula
2019-10-01 14:08               ` Jani Nikula
2019-10-01 17:26 ` ✓ Fi.CI.BAT: success for drm/print: add and use drm_debug_enabled() (rev3) Patchwork
2019-10-02  1:45 ` ✓ Fi.CI.IGT: " Patchwork
     [not found] ` <cover.1569329774.git.jani.nikula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-10-02 14:11   ` [PATCH v2 0/9] drm/print: add and use drm_debug_enabled() Jani Nikula
2019-10-02 14:11     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zlhwl0t.fsf@riseup.net \
    --to=currojerez@riseup.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.