All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	peter.maydell@linaro.org, "Thomas Huth" <thuth@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: fix modules-test with no default machine
Date: Wed, 28 Aug 2019 16:19:19 +0100	[thread overview]
Message-ID: <875zmh5nd4.fsf@linaro.org> (raw)
In-Reply-To: <20190827140241.20818-2-marcandre.lureau@redhat.com>


Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Fixes: eb062cfa733 ("tests: add module loading test")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/modules-test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index a8118e9042..d1a6ace218 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -1,12 +1,14 @@
>  #include "qemu/osdep.h"
>  #include "libqtest.h"
>
> +const char common_args[] = "-nodefaults -machine none";
> +
>  static void test_modules_load(const void *data)
>  {
>      QTestState *qts;
>      const char **args = (const char **)data;
>
> -    qts = qtest_init(NULL);
> +    qts = qtest_init(common_args);
>      qtest_module_load(qts, args[0], args[1]);
>      qtest_quit(qts);
>  }


--
Alex Bennée


  parent reply	other threads:[~2019-08-28 15:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 14:02 [Qemu-devel] [PATCH 1/2] build-sys: build ui-spice-app as a module Marc-André Lureau
2019-08-27 14:02 ` [Qemu-devel] [PATCH 2/2] tests: fix modules-test with no default machine Marc-André Lureau
2019-08-27 14:46   ` Thomas Huth
2019-08-27 14:52     ` Peter Maydell
2019-09-02  9:50       ` Alex Bennée
2019-09-03  7:52         ` Peter Maydell
2019-08-28 15:19   ` Alex Bennée [this message]
2019-08-27 14:55 ` [Qemu-devel] [PATCH 1/2] build-sys: build ui-spice-app as a module Thomas Huth
2019-08-28 15:19 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zmh5nd4.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.