From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 04/12] drm/i915/execlists: Refactor CSB
 state machine
Date: Mon, 01 Jul 2019 14:49:48 +0300
Message-ID: <875zom3rfn.fsf@gaia.fi.intel.com>
References: <20190701100502.15639-1-chris@chris-wilson.co.uk>
 <20190701100502.15639-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7B0BD89AB6
 for <intel-gfx@lists.freedesktop.org>; Mon,  1 Jul 2019 11:49:55 +0000 (UTC)
In-Reply-To: <20190701100502.15639-4-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gRGFuaWVs
ZSBwb2ludGVkIG91dCB0aGF0IHRoZSBDU0Igc3RhdHVzIGluZm9ybWF0aW9uIHdpbGwgY2hhbmdl
IHdpdGgKPiBUaWdlcmxha2UgYW5kIHN1Z2dlc3RlZCB0aGF0IHdlIGNvdWxkIHJlYXJyYW5nZSBv
dXIgc3RhdGUgbWFjaGluZSB0bwo+IGhpZGUgdGhlIGRpZmZlcmVuY2VzIGluIGdlbmVyYXRpb24u
IGdjYyBhbHNvIHByZWZlcnMgdGhlIGV4cGxpY2l0IHN0YXRlCj4gbWFjaGluZSwgc28gbWFrZSBp
dCBzbzoKPgo+IHByb2Nlc3NfY3NiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTk4
MCAgICAxOTY3ICAgICAtMTMKPgo+IFN1Z2dlc3RlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJp
byA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJp
cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsZSBDZXJhb2xv
IFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBDYzogVHZydGtvIFVy
c3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWlrYSBLdW9wcGFs
YSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2d0L2ludGVsX2xyYy5jIHwgNjQgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0K
PiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+Cj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPiBpbmRleCA0NzFlMTM0ZGUxODYuLjk1M2Iz
OTM4YTg1ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMu
Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jCj4gQEAgLTEyNzks
NiArMTI3OSwzMCBAQCByZXNldF9pbl9wcm9ncmVzcyhjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5l
X2V4ZWNsaXN0cyAqZXhlY2xpc3RzKQo+ICAJcmV0dXJuIHVubGlrZWx5KCFfX3Rhc2tsZXRfaXNf
ZW5hYmxlZCgmZXhlY2xpc3RzLT50YXNrbGV0KSk7Cj4gIH0KPiAgCj4gK2VudW0gY3NiX3N0ZXAg
ewo+ICsJQ1NCX05PUCwKPiArCUNTQl9QUk9NT1RFLAo+ICsJQ1NCX1BSRUVNUFQsCj4gKwlDU0Jf
Q09NUExFVEUsCj4gK307Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGVudW0gY3NiX3N0ZXAKPiArY3Ni
X3BhcnNlKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMsIGNv
bnN0IHUzMiAqY3NiKQo+ICt7Cj4gKwl1bnNpZ25lZCBpbnQgc3RhdHVzID0gKmNzYjsKCkNvdWxk
IGJlIGNvbnN0IHUzMiBhc3dlbGwgKHN0eWxpc3RpYykuCgpKdXN0IG1ha2VzIG1lIHBvbmRlciB3
aHkgeW91IHdhbnQgdG8gcmVhZCBjc2IgaW4gaGVyZQphbmQgbm90IGluIHRoZSBjYWxsc2l0ZS4K
ClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv
bT4KCj4gKwo+ICsJaWYgKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRVU19JRExFX0FDVElWRSkKPiAr
CQlyZXR1cm4gQ1NCX1BST01PVEU7Cj4gKwo+ICsJaWYgKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRV
U19QUkVFTVBURUQpCj4gKwkJcmV0dXJuIENTQl9QUkVFTVBUOwo+ICsKPiArCWlmICgqZXhlY2xp
c3RzLT5hY3RpdmUpCj4gKwkJcmV0dXJuIENTQl9DT01QTEVURTsKPiArCj4gKwlyZXR1cm4gQ1NC
X05PUDsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2Vu
Z2luZV9jcyAqZW5naW5lKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAq
IGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiBAQCAtMTMxNiw4ICsxMzQw
LDYgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n
aW5lKQo+ICAJcm1iKCk7Cj4gIAo+ICAJZG8gewo+IC0JCXVuc2lnbmVkIGludCBzdGF0dXM7Cj4g
LQo+ICAJCWlmICgrK2hlYWQgPT0gbnVtX2VudHJpZXMpCj4gIAkJCWhlYWQgPSAwOwo+ICAKPiBA
QCAtMTM0MywxMCArMTM2NSwxNiBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50
ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJCSAgZW5naW5lLT5uYW1lLCBoZWFkLAo+ICAJCQkg
IGJ1ZlsyICogaGVhZCArIDBdLCBidWZbMiAqIGhlYWQgKyAxXSk7Cj4gIAo+IC0JCXN0YXR1cyA9
IGJ1ZlsyICogaGVhZF07Cj4gLQkJaWYgKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRVU19JRExFX0FD
VElWRSkgewo+ICsJCXN3aXRjaCAoY3NiX3BhcnNlKGV4ZWNsaXN0cywgYnVmICsgMiAqIGhlYWQp
KSB7Cj4gKwkJY2FzZSBDU0JfUFJFRU1QVDogLyogY2FuY2VsIG9sZCBpbmZsaWdodCwgcHJlcGFy
ZSBmb3Igc3dpdGNoICovCj4gKwkJCXRyYWNlX3BvcnRzKGV4ZWNsaXN0cywgInByZWVtcHRlZCIs
IGV4ZWNsaXN0cy0+YWN0aXZlKTsKPiArCj4gKwkJCXdoaWxlICgqZXhlY2xpc3RzLT5hY3RpdmUp
Cj4gKwkJCQlleGVjbGlzdHNfc2NoZWR1bGVfb3V0KCpleGVjbGlzdHMtPmFjdGl2ZSsrKTsKPiAr
Cj4gKwkJCS8qIGZhbGx0aHJvdWdoICovCj4gKwkJY2FzZSBDU0JfUFJPTU9URTogLyogc3dpdGNo
IHBlbmRpbmcgdG8gaW5mbGlnaHQgKi8KPiAgCQkJR0VNX0JVR19PTigqZXhlY2xpc3RzLT5hY3Rp
dmUpOwo+IC1wcm9tb3RlOgo+ICAJCQlHRU1fQlVHX09OKCFhc3NlcnRfcGVuZGluZ192YWxpZChl
eGVjbGlzdHMsICJwcm9tb3RlIikpOwo+ICAJCQlleGVjbGlzdHMtPmFjdGl2ZSA9Cj4gIAkJCQlt
ZW1jcHkoZXhlY2xpc3RzLT5pbmZsaWdodCwKPiBAQCAtMTM1NSwyNSArMTM4MywxNyBAQCBzdGF0
aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJ
CQkgICAgICAgc2l6ZW9mKCpleGVjbGlzdHMtPnBlbmRpbmcpKTsKPiAgCQkJZXhlY2xpc3RzLT5w
ZW5kaW5nWzBdID0gTlVMTDsKPiAgCj4gKwkJCXRyYWNlX3BvcnRzKGV4ZWNsaXN0cywgInByb21v
dGVkIiwgZXhlY2xpc3RzLT5hY3RpdmUpOwo+ICsKPiAgCQkJaWYgKGVuYWJsZV90aW1lc2xpY2Uo
ZW5naW5lKSkKPiAgCQkJCW1vZF90aW1lcigmZXhlY2xpc3RzLT50aW1lciwgamlmZmllcyArIDEp
Owo+ICAKPiAgCQkJaWYgKCFpbmplY3RfcHJlZW1wdF9oYW5nKGV4ZWNsaXN0cykpCj4gIAkJCQly
aW5nX3NldF9wYXVzZWQoZW5naW5lLCAwKTsKPiAtCQl9IGVsc2UgaWYgKHN0YXR1cyAmIEdFTjhf
Q1RYX1NUQVRVU19QUkVFTVBURUQpIHsKPiAtCQkJc3RydWN0IGk5MTVfcmVxdWVzdCAqIGNvbnN0
ICpwb3J0ID0gZXhlY2xpc3RzLT5hY3RpdmU7Cj4gLQo+IC0JCQl0cmFjZV9wb3J0cyhleGVjbGlz
dHMsICJwcmVlbXB0ZWQiLCBleGVjbGlzdHMtPmFjdGl2ZSk7Cj4gLQo+IC0JCQl3aGlsZSAoKnBv
cnQpCj4gLQkJCQlleGVjbGlzdHNfc2NoZWR1bGVfb3V0KCpwb3J0KyspOwo+IC0KPiAtCQkJZ290
byBwcm9tb3RlOwo+IC0JCX0gZWxzZSBpZiAoKmV4ZWNsaXN0cy0+YWN0aXZlKSB7Cj4gLQkJCXN0
cnVjdCBpOTE1X3JlcXVlc3QgKnJxID0gKmV4ZWNsaXN0cy0+YWN0aXZlKys7Cj4gKwkJCWJyZWFr
Owo+ICAKPiAtCQkJdHJhY2VfcG9ydHMoZXhlY2xpc3RzLCAiY29tcGxldGVkIiwKPiAtCQkJCSAg
ICBleGVjbGlzdHMtPmFjdGl2ZSAtIDEpOwo+ICsJCWNhc2UgQ1NCX0NPTVBMRVRFOiAvKiBwb3J0
MCBjb21wbGV0ZWQsIGFkdmFuY2VkIHRvIHBvcnQxICovCj4gKwkJCXRyYWNlX3BvcnRzKGV4ZWNs
aXN0cywgImNvbXBsZXRlZCIsIGV4ZWNsaXN0cy0+YWN0aXZlKTsKPiAgCj4gIAkJCS8qCj4gIAkJ
CSAqIFdlIHJlbHkgb24gdGhlIGhhcmR3YXJlIGJlaW5nIHN0cm9uZ2x5Cj4gQEAgLTEzODEsMTEg
KzE0MDEsMTUgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9j
cyAqZW5naW5lKQo+ICAJCQkgKiBjb2hlcmVudCAodmlzaWJsZSBmcm9tIHRoZSBDUFUpIGJlZm9y
ZSB0aGUKPiAgCQkJICogdXNlciBpbnRlcnJ1cHQgYW5kIENTQiBpcyBwcm9jZXNzZWQuCj4gIAkJ
CSAqLwo+IC0JCQlHRU1fQlVHX09OKCFpOTE1X3JlcXVlc3RfY29tcGxldGVkKHJxKSk7Cj4gLQkJ
CWV4ZWNsaXN0c19zY2hlZHVsZV9vdXQocnEpOwo+ICsJCQlHRU1fQlVHX09OKCFpOTE1X3JlcXVl
c3RfY29tcGxldGVkKCpleGVjbGlzdHMtPmFjdGl2ZSkpOwo+ICsJCQlleGVjbGlzdHNfc2NoZWR1
bGVfb3V0KCpleGVjbGlzdHMtPmFjdGl2ZSsrKTsKPiAgCj4gIAkJCUdFTV9CVUdfT04oZXhlY2xp
c3RzLT5hY3RpdmUgLSBleGVjbGlzdHMtPmluZmxpZ2h0ID4KPiAgCQkJCSAgIGV4ZWNsaXN0c19u
dW1fcG9ydHMoZXhlY2xpc3RzKSk7Cj4gKwkJCWJyZWFrOwo+ICsKPiArCQljYXNlIENTQl9OT1A6
Cj4gKwkJCWJyZWFrOwo+ICAJCX0KPiAgCX0gd2hpbGUgKGhlYWQgIT0gdGFpbCk7Cj4gIAo+IC0t
IAo+IDIuMjAuMQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=