From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E53C31E44 for ; Fri, 14 Jun 2019 09:43:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC2582084E for ; Fri, 14 Jun 2019 09:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbfFNJnt (ORCPT ); Fri, 14 Jun 2019 05:43:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:54300 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbfFNJnt (ORCPT ); Fri, 14 Jun 2019 05:43:49 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 02:43:49 -0700 X-ExtLoop1: 1 Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.150]) by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2019 02:43:46 -0700 From: Jani Nikula To: Nathan Huckleberry , jsanka@codeaurora.org, robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com Subject: Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 14 Jun 2019 12:46:44 +0300 Message-ID: <875zp8wlbv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 13 Jun 2019, Nathan Huckleberry wrote: > Hey all, > > I'm looking into cleaning up ignored warnings in the kernel so we can > remove compiler flags to ignore warnings. Wholeheartedly agreed on the goal. > There are several unused variables in dpu_formats.c > ('dpu_format_map_tile', 'dpu_format_map_p010', > 'dpu_format_map_p010_ubwc', 'dpu_format_map_tp10_ubwc'). > They look like modifiers that were never implemented. I'd like to > remove these variables if there are no plans moving forward to > implement them. Otherwise I'll just leave them. > > https://github.com/ClangBuiltLinux/linux/issues/528 No opinion on the said variables above, but, FWIW, personally I think it's fine to add the cflags to supress warnings locally where needed in order to be able to achieve the greater goal of removing the cflags globally. In drivers/gpu/drm/i915/Makefile we actually go for much stricter warnings than the kernel defaults, and disable a more limited and tailored set of warnings. You can do this both on a subdir and file level with subdir-ccflags-y and CFLAGS_filename.o, respectively. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c Date: Fri, 14 Jun 2019 12:46:44 +0300 Message-ID: <875zp8wlbv.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Nathan Huckleberry , jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxMyBKdW4gMjAxOSwgTmF0aGFuIEh1Y2tsZWJlcnJ5IDxuaHVja0Bnb29nbGUuY29t PiB3cm90ZToKPiBIZXkgYWxsLAo+Cj4gSSdtIGxvb2tpbmcgaW50byBjbGVhbmluZyB1cCBpZ25v cmVkIHdhcm5pbmdzIGluIHRoZSBrZXJuZWwgc28gd2UgY2FuCj4gcmVtb3ZlIGNvbXBpbGVyIGZs YWdzIHRvIGlnbm9yZSB3YXJuaW5ncy4KCldob2xlaGVhcnRlZGx5IGFncmVlZCBvbiB0aGUgZ29h bC4KCj4gVGhlcmUgYXJlIHNldmVyYWwgdW51c2VkIHZhcmlhYmxlcyBpbiBkcHVfZm9ybWF0cy5j Cj4gKCdkcHVfZm9ybWF0X21hcF90aWxlJywgJ2RwdV9mb3JtYXRfbWFwX3AwMTAnLAo+ICdkcHVf Zm9ybWF0X21hcF9wMDEwX3Vid2MnLCAnZHB1X2Zvcm1hdF9tYXBfdHAxMF91YndjJykuCj4gVGhl eSBsb29rIGxpa2UgbW9kaWZpZXJzIHRoYXQgd2VyZSBuZXZlciBpbXBsZW1lbnRlZC4gSSdkIGxp a2UgdG8KPiByZW1vdmUgdGhlc2UgdmFyaWFibGVzIGlmIHRoZXJlIGFyZSBubyBwbGFucyBtb3Zp bmcgZm9yd2FyZCB0bwo+IGltcGxlbWVudCB0aGVtLiBPdGhlcndpc2UgSSdsbCBqdXN0IGxlYXZl IHRoZW0uCj4KPiBodHRwczovL2dpdGh1Yi5jb20vQ2xhbmdCdWlsdExpbnV4L2xpbnV4L2lzc3Vl cy81MjgKCk5vIG9waW5pb24gb24gdGhlIHNhaWQgdmFyaWFibGVzIGFib3ZlLCBidXQsIEZXSVcs IHBlcnNvbmFsbHkgSSB0aGluawppdCdzIGZpbmUgdG8gYWRkIHRoZSBjZmxhZ3MgdG8gc3VwcmVz cyB3YXJuaW5ncyBsb2NhbGx5IHdoZXJlIG5lZWRlZCBpbgpvcmRlciB0byBiZSBhYmxlIHRvIGFj aGlldmUgdGhlIGdyZWF0ZXIgZ29hbCBvZiByZW1vdmluZyB0aGUgY2ZsYWdzCmdsb2JhbGx5LgoK SW4gZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZpbGUgd2UgYWN0dWFsbHkgZ28gZm9yIG11Y2gg c3RyaWN0ZXIKd2FybmluZ3MgdGhhbiB0aGUga2VybmVsIGRlZmF1bHRzLCBhbmQgZGlzYWJsZSBh IG1vcmUgbGltaXRlZCBhbmQKdGFpbG9yZWQgc2V0IG9mIHdhcm5pbmdzLgoKWW91IGNhbiBkbyB0 aGlzIGJvdGggb24gYSBzdWJkaXIgYW5kIGZpbGUgbGV2ZWwgd2l0aCBzdWJkaXItY2NmbGFncy15 CmFuZCBDRkxBR1NfZmlsZW5hbWUubywgcmVzcGVjdGl2ZWx5LgoKQlIsCkphbmkuCgoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlz dApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v