From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH2CX-0003tb-Uc for ath10k@lists.infradead.org; Thu, 18 Apr 2019 08:15:23 +0000 Received: by mail-ed1-f67.google.com with SMTP id i13so1035914edf.11 for ; Thu, 18 Apr 2019 01:15:21 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v2] ath10k: fix different tx duration output In-Reply-To: <298a645b17aac0f5c466f011225533b0@codeaurora.org> References: <1555489045-18070-1-git-send-email-leiwa@codeaurora.org> <87mukprnie.fsf@toke.dk> <298a645b17aac0f5c466f011225533b0@codeaurora.org> Date: Thu, 18 Apr 2019 09:07:45 +0100 Message-ID: <875zrbrb1q.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: leiwa@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org bGVpd2FAY29kZWF1cm9yYS5vcmcgd3JpdGVzOgoKPiBPbiAyMDE5LTA0LTE3IDE3OjI2LCBUb2tl IEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+IExlaSBXYW5nIDxsZWl3YUBjb2RlYXVyb3Jh Lm9yZz4gd3JpdGVzOgo+PiAKPj4+IFRYIGR1cmF0aW9uIG91dHB1dCBvZiB0eF9zdGF0cyBpbiBk ZWJ1Z2ZzIGFuZCBzdGF0aW9uIGR1bXAgaGFkIGJpZwo+Pj4gZGlmZmVyZW5jZSBiZWNhdXNlIHRo ZXkgZ290IHR4IGR1cmF0aW9uIHZhbHVlIGZyb20gZGlmZmVyZW50IHN0YXRpc3RpYwo+Pj4gZGF0 YS4gV2Ugc2hvdWxkIHVzZSB0aGUgc2FtZSBzdGF0aXN0aWMgZGF0YS4KPj4gCj4+IFNvIGFyZSB5 b3Ugc3VyZSB5b3UgcGlja2VkIHRoZSBtb3N0IGFjY3VyYXRlIG9uZSBvZiB0aGUgdHdvPyA6KQo+ PiAKPj4gLVRva2UKPgo+IEhpIFRva2UsCj4KPiBZZXMuCj4gTm93IGZvciBhdGgxMGssIHRoZXJl IGFyZSB0d28gd2F5cyB0byBnZXQgdHggZHVyYXRpb24gb3V0cHV0Lgo+IE9uZSBpcyBnb3QgZnJv bSB0eF9zdGF0cyBpbiBkZWJ1Z2ZzIHJlcG9ydGVkIGJ5IGZpcm13YXJlLiBJdCBpcyBhIHRvdGFs IAo+IHZhbHVlIGluY2x1ZGluZyBhbGwgdGhlIGZyYW1lcyB3aGljaCBjcmVhdGVkIGJ5IGhvc3Qg YW5kIGZpcm13YXJlIHNlbnQgCj4gdG8gdGhlIHBlZXIuCj4gQW5kIHRoZSBzZWNvbmQgaXMgY2Fs Y3VsYXRlZCBmcm9tIAo+IGF0aDEwa19odHRfcnhfdHhfY29tcGxfaW5kKCktLT5pZWVlODAyMTFf c3RhX3JlZ2lzdGVyX2FpcnRpbWUoKSwgaGVyZSAKPiB0aGUgdHggZHVyYXRpb24ganVzdCBpbmNs dWRlcyB0aGUgZGF0YSBmcmFtZXMgc2VudCBmcm9tIGhvc3QgdG8gdGhlIAo+IHBlZXIuCgpTbyB0 aGUgZGlmZmVyZW5jZSBpcyB0aGF0IHRoZSBmb3JtZXIgaW5jbHVkZXMgY29udHJvbCBmcmFtZXMg YXMgd2VsbD8gSXMKdGhhdCB0aGUgb25seSBkaWZmZXJlbmNlPyBBbmQgd2hhdCBleGFjdGx5IGlz IGEgImJpZyBkaWZmZXJlbmNlIiAoZnJvbQp0aGUgY29tbWl0IG1lc3NhZ2UpPwoKPiBTbyB0aGUg Zmlyc3QgdmFsdWUgaXMgcHJlZmVyYWJsZSBmb3Igc3RhdGlvbiBkdW1wLgoKSG1tLCBJJ20gbm90 IHN1cmUgaWYgSSBhZ3JlZSB3aXRoIHRoaXMuIEkgc3BlY2lmaWNhbGx5IGFkZGVkIHRoZQp0eF9k dXJhdGlvbiB0byB0aGUgc3RhdGlvbiBkdW1wIHRvIGJlIGFibGUgdG8gZ2V0IHRoZSB2YWx1ZXMg dXNlZCBieSB0aGUKYWlydGltZSBzY2hlZHVsZXIuIFRoaXMgYnJlYWtzIHdpdGggdGhpcyBwYXRj aC4KCi1Ub2tlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6425AC10F0B for ; Thu, 18 Apr 2019 08:15:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2690D214DA for ; Thu, 18 Apr 2019 08:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387971AbfDRIPW convert rfc822-to-8bit (ORCPT ); Thu, 18 Apr 2019 04:15:22 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:34153 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfDRIPV (ORCPT ); Thu, 18 Apr 2019 04:15:21 -0400 Received: by mail-ed1-f68.google.com with SMTP id a6so1076985edv.1 for ; Thu, 18 Apr 2019 01:15:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=ijbm3Iix0w0z8E7I3HpvHzANFijZg+oT1HFJFsblOw8=; b=To3CxK0kPNV38OiQsQJpACuiC/7n6paXDHPp0NPjpZBF6VTo5iKtK6D6ExGll1T91s Ri31y59cZYNSDlfaIrn+aokhJtPlLHiqqNq3JHYvBEPEjpDxk9BH9rTWsobQ/iCLqOUJ BVgt7wcyJ79ValpZ+hAhq8p0hesFam639d9G3/CVVWWAFzRibhOafp5jRSAzSSzamxFs BRUFkvNEUf1RKXOYmh6mC4kjR2mv+dZzwtFn7bBmaN5PfcYMZbOjHSbjQSz2PbOPLi6H kcXCCYQuXLgtqmG0uAAxmF/OId6p4OS0TdtyvRsW5iPYGXSY/5awm07L/rqkjsXSrXh+ WRBw== X-Gm-Message-State: APjAAAUMy262LLSdOqqpIPMdaHjXaiWkxAOS1BkokNCbYq5odpD9b+C3 5Z7SOoFLAGed+B4g0HvjQPe3PAUJLDQ= X-Google-Smtp-Source: APXvYqxhcFIzaOE2CEKkQ57kd6iET2IWbEB6iZIoYiL98D4LAc8eltTtUdTqSDlhZlcv9S8c+q7C7g== X-Received: by 2002:a50:b3b1:: with SMTP id s46mr60004952edd.202.1555575319711; Thu, 18 Apr 2019 01:15:19 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id t9sm251257ejg.54.2019.04.18.01.15.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 01:15:19 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 714D21800E8; Thu, 18 Apr 2019 09:07:45 +0100 (+01) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: leiwa@codeaurora.org Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath10k: fix different tx duration output In-Reply-To: <298a645b17aac0f5c466f011225533b0@codeaurora.org> References: <1555489045-18070-1-git-send-email-leiwa@codeaurora.org> <87mukprnie.fsf@toke.dk> <298a645b17aac0f5c466f011225533b0@codeaurora.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 18 Apr 2019 09:07:45 +0100 Message-ID: <875zrbrb1q.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org leiwa@codeaurora.org writes: > On 2019-04-17 17:26, Toke Høiland-Jørgensen wrote: >> Lei Wang writes: >> >>> TX duration output of tx_stats in debugfs and station dump had big >>> difference because they got tx duration value from different statistic >>> data. We should use the same statistic data. >> >> So are you sure you picked the most accurate one of the two? :) >> >> -Toke > > Hi Toke, > > Yes. > Now for ath10k, there are two ways to get tx duration output. > One is got from tx_stats in debugfs reported by firmware. It is a total > value including all the frames which created by host and firmware sent > to the peer. > And the second is calculated from > ath10k_htt_rx_tx_compl_ind()-->ieee80211_sta_register_airtime(), here > the tx duration just includes the data frames sent from host to the > peer. So the difference is that the former includes control frames as well? Is that the only difference? And what exactly is a "big difference" (from the commit message)? > So the first value is preferable for station dump. Hmm, I'm not sure if I agree with this. I specifically added the tx_duration to the station dump to be able to get the values used by the airtime scheduler. This breaks with this patch. -Toke