From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/6] drm/vc4: Make vc4_lbm_size() return 0 when vertical scaling is disabled Date: Thu, 15 Nov 2018 12:39:56 -0800 Message-ID: <875zwy2hyb.fsf@anholt.net> References: <20181115103721.25601-1-boris.brezillon@bootlin.com> <20181115103721.25601-2-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1850090930==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 37C676E686 for ; Thu, 15 Nov 2018 20:39:59 +0000 (UTC) In-Reply-To: <20181115103721.25601-2-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: Boris Brezillon , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1850090930== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Boris Brezillon writes: > LBM is not needed when vertical scaling is disabled. Return 0 in this > case to avoid allocating LBM memory that will anyway be unused. > > While at it, drop the test on ->is_unity which is now redundant. r-b --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvt2Z0ACgkQtdYpNtH8 nuipGA/7B5CSRSV2yRJVgEsrHgis5Vshhg4xq4dYmD+rhQUNqr3cEPwPPrZujmIb yJ42XMP0hMGfaIPCVTpgYrKytz12Lkl3O4drnzXki2FX+7wZ1LEdt9SfqdlL/The /k1XUljIhuDtwOm+xlx46TijH2g78LG44pwUuLXxPh8B0zo5Z5ShbidOWhHHrkNA /iQXaO90yOggKmmTv2E3uTdj6cVmuuQStXPLOqJl/Gy1rA6X0R3kRMhGjjOaqa7v MVzyrp887GjHhPxI2Fs3M2hnjBbM5wv43dfDKTleB3f/7AgMwyyjtq5ZqZ81AtAH eC+SCYVAcrNVCX4XCjl3klSAPl4ADiQXnjRRnU/1POLx/p7TtVDOwV2dmxg5YzNF ybo1OX+FtAa+iwft9WWJcw+98HvUu5xmuCEFmjU0nqTRwUAVXvAXf2Irrx1T7VHe /OQNWJUVNXn0d+cnwIGwsxpmu39WDE7SY5TxoO1s3RH0z+zbde2TlXH0vUwtooKH SJ5t+Bp8pMOI5AzrRVXtVsSN3bMI/CiJkRRlttArTcvhgl4qR7RZ53nM+C72yN5w +BCAmInjI0RW9UvOvtBok4IfwR35vhNCNjODXkXITS68cEwlEZAENzl4Ya4GX4/r 9vTgwXQ+DERMoMf2E7B3/EY3XsYw0wj5p6wX2QdG/yxrcQzTE20= =4g1Y -----END PGP SIGNATURE----- --=-=-=-- --===============1850090930== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1850090930==--