Re: [igt-dev] [PATCH i-g-t] tests/pm_backlight.c: Fix brightness failure with system suspend

From: Jani Nikula <jani.nikula@intel.com>
To: Jyoti Yadav <jyoti.r.yadav@intel.com>, igt-dev@lists.freedesktop.org
Cc: Jyoti Yadav <jyoti.r.yadav@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/pm_backlight.c: Fix brightness failure with system suspend
Date: Tue, 13 Nov 2018 13:57:55 +0200	[thread overview]
Message-ID: <875zx1gpfg.fsf@intel.com> (raw)
In-Reply-To: <1541676018-6502-1-git-send-email-jyoti.r.yadav@intel.com>

On Thu, 08 Nov 2018, Jyoti Yadav <jyoti.r.yadav@intel.com> wrote:
> This patch tries to fix the faliure occuring during subtest
> "fade_with_suspend". Failure is occuring because, brightness
> value is being checked before driver initializes fully after resume.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107847
> Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

That's not how Signed-off-by works. Please read [1] and [2] with care.

BR,
Jani.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
[2] https://developercertificate.org/

> ---
>  tests/pm_backlight.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
> index 32808cd..159366c 100644
> --- a/tests/pm_backlight.c
> +++ b/tests/pm_backlight.c
> @@ -177,12 +177,8 @@ test_fade_with_suspend(struct context *context, igt_output_t *output)
>  {
>  	igt_require(igt_setup_runtime_pm());
>  
> -	kmstest_set_connector_dpms(output->display->drm_fd,
> -				   output->config.connector,
> -				   DRM_MODE_DPMS_OFF);
> -	igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> -
>  	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
> +	igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
>  
>  	test_fade(context);
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev