All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/14] drm/i915: Restrict gen6_reset_rps_interrupts to gen6+
Date: Mon, 13 Aug 2018 19:09:06 +0300	[thread overview]
Message-ID: <87600ejljx.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180812223642.24865-2-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Do not call gen6_reset_rps_interrupts() when we know the registers do not
> exist.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

This makes me wonder about adding some known gen6+ debug
register range assertions to I915_WRITE when gen < 6.

i915.mmio_debug for all (gens) :)

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 03654f5f68c3..9a01560c5bd1 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8260,7 +8260,7 @@ void intel_sanitize_gt_powersave(struct drm_i915_private *dev_priv)
>  
>  	if (INTEL_GEN(dev_priv) >= 11)
>  		gen11_reset_rps_interrupts(dev_priv);
> -	else
> +	else if (INTEL_GEN(dev_priv) >= 6)
>  		gen6_reset_rps_interrupts(dev_priv);
>  }
>  
> -- 
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-08-13 16:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-12 22:36 [PATCH 01/14] drm/i915: Cleanup gt powerstate from gem Chris Wilson
2018-08-12 22:36 ` [PATCH 02/14] drm/i915: Restrict gen6_reset_rps_interrupts to gen6+ Chris Wilson
2018-08-13 16:09   ` Mika Kuoppala [this message]
2018-08-12 22:36 ` [PATCH 03/14] drm/i915: Disable runtime-pm using lowlevel functions if !HAS_RC6 Chris Wilson
2018-08-14 12:06   ` Mika Kuoppala
2018-08-14 12:15     ` Chris Wilson
2018-08-14 12:47   ` Mika Kuoppala
2018-08-12 22:36 ` [PATCH 04/14] drm/i915: Only skip connector output for disable_display Chris Wilson
2018-08-15 20:04   ` Imre Deak
2018-08-12 22:36 ` [PATCH 05/14] drm/i915: Explicitly take the init-power domain Chris Wilson
2018-08-12 22:36 ` [PATCH 06/14] drm/i915: Attach the pci match data to the device upon creation Chris Wilson
2018-08-12 22:36 ` [PATCH 07/14] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable Chris Wilson
2018-08-12 22:36 ` [PATCH 08/14] drm/i915: Track all held rpm wakerefs Chris Wilson
2018-08-12 22:36 ` [PATCH 09/14] drm/i915: Markup paired operations on wakerefs Chris Wilson
2018-08-12 22:36 ` [PATCH 10/14] drm/i915: Syntatic sugar for using intel_runtime_pm Chris Wilson
2018-08-12 22:36 ` [PATCH 11/14] drm/i915: Markup paired operations on display power domains Chris Wilson
2018-08-12 22:36 ` [PATCH 12/14] drm/i915/dp: Markup pps lock power well Chris Wilson
2018-08-12 22:36 ` [PATCH 13/14] drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice Chris Wilson
2018-08-12 22:36 ` [PATCH 14/14] drm/i915: Enable runtime-pm debugging by default for CI Chris Wilson
2018-08-12 23:08 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem Patchwork
2018-08-12 23:13 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-08-12 23:32 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-13  1:03 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-13 16:04 ` [PATCH 01/14] " Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87600ejljx.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.