From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats Date: Fri, 27 Jul 2018 13:55:03 -0700 Message-ID: <8760101jrs.fsf@anholt.net> References: <20180725122907.13702-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <20180725122907.13702-1-boris.brezillon@bootlin.com> Sender: stable-owner@vger.kernel.org Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Boris Brezillon , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Boris Brezillon writes: > When there's no scaling requested ->is_unity should be true no matter > the format. > > Also, when no scaling is requested and we have a multi-planar YUV > format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only > set ->x_scaling[0] to VC4_SCALING_PPF. > > Doing this fixes an hardly visible artifact (seen when using modetest > and a rather big overlay plane in YUV420). > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > Cc: > Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAltbhqcACgkQtdYpNtH8 nuh7+Q//S5RK56Y8WCjormQsZ1j/1v0Sipzsl7Yj/7kilmRRvlnAQ3f3w5SOSqlW 30yT11uYRmCrpfxtnv6TfHt6fpjJzT2/b3CczRcdr6gWvngbXFICI2NimE28i14j pTJpYXk8BxL5Y7vjB/otS08f6T45aEkN7mGLx7Is9Tkj1+qh0rGLFVF5vt8Ne4sq fpisW55sPU3WMJ2OzFLPDfd46OfAh0F9LxCdtsjSXGDrxMP2hUlcspm/GrqA+Qm6 ghuww1/mVZHxJgQeck7kKtT6dT6cB8yGPAPDf4oVC+U5+wAjM55ZzVHX+IpFZf1u 3ULMy4d2ssMM3CpMSN07em43JeKr4GM72v4W8HsT3lo3eT90C2sp9fXu4wNwK03y 5r3BDIahC64MUN6rS7vMnsGj8gpuRVD5codOchOpGqC9e1nDO0T9DhrRgYPLvPpo vqmhf4Z4OSpiW/phwRxbspOK4CcrB0nH0uz02DFofjmpzviyRXmW+WzvBY9+K+mT 2+GB66hGQENYOorhMW6vo3osc/49q//GC0r7YOheJP9u65Ka9C4xnsVZjGnUo06C GMDuJ0pVkO2X7Hb/SmSKEKlnjQs2xRfzPOlhL66gB38R7BTqgngNXHaZoh1ymwM6 wbYRUt/KPfx/mvc4KdmohETRiXlq5pQ9L93dKSyuM0QYke7bEo8= =3LNf -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from anholt.net ([50.246.234.109]:37086 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389479AbeG0WSm (ORCPT ); Fri, 27 Jul 2018 18:18:42 -0400 From: Eric Anholt To: Boris Brezillon Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Boris Brezillon , stable@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats In-Reply-To: <20180725122907.13702-1-boris.brezillon@bootlin.com> References: <20180725122907.13702-1-boris.brezillon@bootlin.com> Date: Fri, 27 Jul 2018 13:55:03 -0700 Message-ID: <8760101jrs.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Boris Brezillon writes: > When there's no scaling requested ->is_unity should be true no matter > the format. > > Also, when no scaling is requested and we have a multi-planar YUV > format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only > set ->x_scaling[0] to VC4_SCALING_PPF. > > Doing this fixes an hardly visible artifact (seen when using modetest > and a rather big overlay plane in YUV420). > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > Cc: > Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAltbhqcACgkQtdYpNtH8 nuh7+Q//S5RK56Y8WCjormQsZ1j/1v0Sipzsl7Yj/7kilmRRvlnAQ3f3w5SOSqlW 30yT11uYRmCrpfxtnv6TfHt6fpjJzT2/b3CczRcdr6gWvngbXFICI2NimE28i14j pTJpYXk8BxL5Y7vjB/otS08f6T45aEkN7mGLx7Is9Tkj1+qh0rGLFVF5vt8Ne4sq fpisW55sPU3WMJ2OzFLPDfd46OfAh0F9LxCdtsjSXGDrxMP2hUlcspm/GrqA+Qm6 ghuww1/mVZHxJgQeck7kKtT6dT6cB8yGPAPDf4oVC+U5+wAjM55ZzVHX+IpFZf1u 3ULMy4d2ssMM3CpMSN07em43JeKr4GM72v4W8HsT3lo3eT90C2sp9fXu4wNwK03y 5r3BDIahC64MUN6rS7vMnsGj8gpuRVD5codOchOpGqC9e1nDO0T9DhrRgYPLvPpo vqmhf4Z4OSpiW/phwRxbspOK4CcrB0nH0uz02DFofjmpzviyRXmW+WzvBY9+K+mT 2+GB66hGQENYOorhMW6vo3osc/49q//GC0r7YOheJP9u65Ka9C4xnsVZjGnUo06C GMDuJ0pVkO2X7Hb/SmSKEKlnjQs2xRfzPOlhL66gB38R7BTqgngNXHaZoh1ymwM6 wbYRUt/KPfx/mvc4KdmohETRiXlq5pQ9L93dKSyuM0QYke7bEo8= =3LNf -----END PGP SIGNATURE----- --=-=-=--