From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/4] drm/i915: Reduce spinlock hold time during notify_ring() interrupt Date: Thu, 28 Jun 2018 11:04:54 +0300 Message-ID: <876023uyjd.fsf@gaia.fi.intel.com> References: <20180627201304.15817-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EA866EB1F for ; Thu, 28 Jun 2018 08:05:37 +0000 (UTC) In-Reply-To: <20180627201304.15817-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQnkgdGFr aW5nIGFkdmFudGFnZSBvZiB0aGUgUkNVIHByb3RlY3Rpb24gb2YgdGhlIHRhc2sgc3RydWN0LCB3 ZSBjYW4gZmluZAo+IHRoZSBhcHByb3ByaWF0ZSBzaWduYWxlciB1bmRlciB0aGUgc3BpbmxvY2sg YW5kIHRoZW4gcmVsZWFzZSB0aGUgc3BpbmxvY2sKPiBiZWZvcmUgd2FraW5nIHRoZSB0YXNrIGFu ZCBzaWduYWxpbmcgdGhlIGZlbmNlLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBh bGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3Vv cHBhbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYyB8IDMyICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9pcnEuYwo+IGluZGV4IDQ2YWFlZjVjMTg1MS4uNTZhMDgwYmM0NDk4IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTExNDUsMjEgKzExNDUsMjMgQEAgc3RhdGljIHZvaWQg aXJvbmxha2VfcnBzX2NoYW5nZV9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gIAo+ICBzdGF0aWMgdm9pZCBub3RpZnlfcmluZyhzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gIHsKPiArCWNvbnN0IHUzMiBzZXFubyA9IGludGVsX2VuZ2luZV9n ZXRfc2Vxbm8oZW5naW5lKTsKPiAgCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxID0gTlVMTDsKPiAr CXN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrID0gTlVMTDsKPiAgCXN0cnVjdCBpbnRlbF93YWl0ICp3 YWl0Owo+ICAKPiAtCWlmICghZW5naW5lLT5icmVhZGNydW1icy5pcnFfYXJtZWQpCj4gKwlpZiAo dW5saWtlbHkoIWVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2FybWVkKSkKPiAgCQlyZXR1cm47Cj4g IAo+ICAJYXRvbWljX2luYygmZW5naW5lLT5pcnFfY291bnQpOwo+IC0Jc2V0X2JpdChFTkdJTkVf SVJRX0JSRUFEQ1JVTUIsICZlbmdpbmUtPmlycV9wb3N0ZWQpOwo+ICsKPiArCXJjdV9yZWFkX2xv Y2soKTsKPiAgCj4gIAlzcGluX2xvY2soJmVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX2xvY2spOwo+ ICAJd2FpdCA9IGVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX3dhaXQ7Cj4gIAlpZiAod2FpdCkgewo+ IC0JCWJvb2wgd2FrZXVwID0gZW5naW5lLT5pcnFfc2Vxbm9fYmFycmllcjsKPiAtCj4gLQkJLyog V2UgdXNlIGEgY2FsbGJhY2sgZnJvbSB0aGUgZG1hLWZlbmNlIHRvIHN1Ym1pdAo+ICsJCS8qCj4g KwkJICogV2UgdXNlIGEgY2FsbGJhY2sgZnJvbSB0aGUgZG1hLWZlbmNlIHRvIHN1Ym1pdAo+ICAJ CSAqIHJlcXVlc3RzIGFmdGVyIHdhaXRpbmcgb24gb3VyIG93biByZXF1ZXN0cy4gVG8KPiAgCQkg KiBlbnN1cmUgbWluaW11bSBkZWxheSBpbiBxdWV1aW5nIHRoZSBuZXh0IHJlcXVlc3QgdG8KPiAg CQkgKiBoYXJkd2FyZSwgc2lnbmFsIHRoZSBmZW5jZSBub3cgcmF0aGVyIHRoYW4gd2FpdCBmb3IK PiBAQCAtMTE3MCwxOSArMTE3MiwyMiBAQCBzdGF0aWMgdm9pZCBub3RpZnlfcmluZyhzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJICogYW5kIHRvIGhhbmRsZSBjb2FsZXNjaW5n IG9mIG11bHRpcGxlIHNlcW5vIHVwZGF0ZXMKPiAgCQkgKiBhbmQgbWFueSB3YWl0ZXJzLgo+ICAJ CSAqLwo+IC0JCWlmIChpOTE1X3NlcW5vX3Bhc3NlZChpbnRlbF9lbmdpbmVfZ2V0X3NlcW5vKGVu Z2luZSksCj4gLQkJCQkgICAgICB3YWl0LT5zZXFubykpIHsKPiArCQlpZiAoaTkxNV9zZXFub19w YXNzZWQoc2Vxbm8sIHdhaXQtPnNlcW5vKSkgewo+ICAJCQlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICp3 YWl0ZXIgPSB3YWl0LT5yZXF1ZXN0Owo+ICAKPiAtCQkJd2FrZXVwID0gdHJ1ZTsKPiAgCQkJaWYg KCF0ZXN0X2JpdChETUFfRkVOQ0VfRkxBR19TSUdOQUxFRF9CSVQsCj4gIAkJCQkgICAgICAmd2Fp dGVyLT5mZW5jZS5mbGFncykgJiYKPiAgCQkJICAgIGludGVsX3dhaXRfY2hlY2tfcmVxdWVzdCh3 YWl0LCB3YWl0ZXIpKQo+ICAJCQkJcnEgPSBpOTE1X3JlcXVlc3RfZ2V0KHdhaXRlcik7Cj4gLQkJ fQo+ICAKPiAtCQlpZiAod2FrZXVwKQo+IC0JCQl3YWtlX3VwX3Byb2Nlc3Mod2FpdC0+dHNrKTsK PiArCQkJdHNrID0gd2FpdC0+dHNrOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCWlmIChlbmdpbmUtPmly cV9zZXFub19iYXJyaWVyKSB7Cj4gKwkJCQlzZXRfYml0KEVOR0lORV9JUlFfQlJFQURDUlVNQiwK PiArCQkJCQkmZW5naW5lLT5pcnFfcG9zdGVkKTsKPiArCQkJCXRzayA9IHdhaXQtPnRzazsKPiAr CQkJfQo+ICsJCX0KPiAgCX0gZWxzZSB7Cj4gIAkJaWYgKGVuZ2luZS0+YnJlYWRjcnVtYnMuaXJx X2FybWVkKQo+ICAJCQlfX2ludGVsX2VuZ2luZV9kaXNhcm1fYnJlYWRjcnVtYnMoZW5naW5lKTsK PiBAQCAtMTE5NSw2ICsxMjAwLDExIEBAIHN0YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQlpOTE1X3JlcXVlc3RfcHV0KHJxKTsKPiAgCX0K PiAgCj4gKwlpZiAodHNrICYmIHRzay0+c3RhdGUgJiBUQVNLX05PUk1BTCkKPiArCQl3YWtlX3Vw X3Byb2Nlc3ModHNrKTsKPiArCj4gKwlyY3VfcmVhZF91bmxvY2soKTsKPiArCj4gIAl0cmFjZV9p bnRlbF9lbmdpbmVfbm90aWZ5KGVuZ2luZSwgd2FpdCk7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xOC4w Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=