All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Alcantara <paulo@paulo.ac>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cifs: Silence uninitialized variable warning
Date: Tue, 19 Jun 2018 13:12:19 +0000	[thread overview]
Message-ID: <87602ec43w.fsf@paulo.ac> (raw)
In-Reply-To: <20180619122530.a7b5ic6jdsl65ez5@kili.mountain>

Dan Carpenter <dan.carpenter@oracle.com> writes:

> This is not really a runtime issue but Smatch complains that:
>
>     fs/cifs/smb2ops.c:1740 smb2_query_symlink()
>     error: uninitialized symbol 'resp_buftype'.
>
> The warning is right that it can be uninitialized...  Also "err_buf"
> would be NULL at this point and we're not supposed to pass NULLs to
> free_rsp_buf() or it might trigger some extra output if we turn on
> debugging.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Paulo Alcantara <palcantara@suse.de>

Thanks
Paulo

  reply	other threads:[~2018-06-19 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 12:25 [PATCH] cifs: Silence uninitialized variable warning Dan Carpenter
2018-06-19 13:12 ` Paulo Alcantara [this message]
2018-06-19 21:32 ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87602ec43w.fsf@paulo.ac \
    --to=paulo@paulo.ac \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.