From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAdgU-0008Dl-WF for qemu-devel@nongnu.org; Mon, 23 Apr 2018 11:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAdgU-0007jP-4Q for qemu-devel@nongnu.org; Mon, 23 Apr 2018 11:47:19 -0400 From: Markus Armbruster References: <20180423084518.2426-1-armbru@redhat.com> <20180423130219.GD6630@localhost.localdomain> Date: Mon, 23 Apr 2018 17:47:00 +0200 In-Reply-To: <20180423130219.GD6630@localhost.localdomain> (Kevin Wolf's message of "Mon, 23 Apr 2018 15:02:19 +0200") Message-ID: <87604ilybv.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] cpus: Fix event order on resume of stopped guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Kevin Wolf writes: > Am 23.04.2018 um 10:45 hat Markus Armbruster geschrieben: >> When resume of a stopped guest immediately runs into block device >> errors, the BLOCK_IO_ERROR event is sent before the RESUME event. >> >> Reproducer: >> >> 1. Create a scratch image >> $ dd if=/dev/zero of=scratch.img bs=1M count=100 >> >> Size doesn't actually matter. >> >> 2. Prepare blkdebug configuration: >> >> $ cat >blkdebug.conf <> [inject-error] >> event = "write_aio" >> errno = "5" >> EOF >> >> Note that errno 5 is EIO. >> >> 3. Run a guest with an additional scratch disk, i.e. with additional >> arguments >> -drive if=none,id=scratch-drive,format=raw,werror=stop,file=blkdebug:blkdebug.conf:scratch.img >> -device virtio-blk-pci,id=scratch,drive=scratch-drive >> >> The blkdebug part makes all writes to the scratch drive fail with >> EIO. The werror=stop pauses the guest on write errors. >> >> 4. Connect to the QMP socket e.g. like this: >> $ socat UNIX:/your/qmp/socket READLINE,history=$HOME/.qmp_history,prompt='QMP> ' >> >> Issue QMP command 'qmp_capabilities': >> QMP> { "execute": "qmp_capabilities" } >> >> 5. Boot the guest. >> >> 6. In the guest, write to the scratch disk, e.g. like this: >> >> # dd if=/dev/zero of=/dev/vdb count=1 >> >> Do double-check the device specified with of= is actually the >> scratch device! >> >> 7. Issue QMP command 'cont': >> QMP> { "execute": "cont" } >> >> After step 6, I get a BLOCK_IO_ERROR event followed by a STOP event. Good. >> >> After step 7, I get BLOCK_IO_ERROR, then RESUME, then STOP. Not so >> good; I'd expect RESUME, then BLOCK_IO_ERROR, then STOP. > > Do you want to rephrase this in the form of a script for qemu-iotests? > > I suppose the 'dd' line can be replaced by a 'qemu-io' monitor command. Makes sense, but I'm quite pretty much a noob there. Perhaps I can copy an existing test and hack it up. Which one would you recommend?