From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0
Date: Mon, 16 Apr 2018 15:42:54 +0100 [thread overview]
Message-ID: <87604rb4b5.fsf@linaro.org> (raw)
In-Reply-To: <aca6055a-1e49-7902-428f-e7e199ed8a12@mail.uni-paderborn.de>
Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes:
> On 04/16/2018 03:54 PM, Alex Bennée wrote:
>> The re-factoring of div_floats changed the order of checking meaning
>> an operation like -inf/0 erroneously raises the divbyzero flag.
>> IEEE-754 (2008) specifies this should only occur for operations on
>> finite operands.
>>
>> We fix this by moving the check on the dividend being Inf/0 to before
>> the divisor is zero check.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>> ---
>> fpu/softfloat.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Tested-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Peter are you going to grab these tags or do you want me to re-spin?
--
Alex Bennée
next prev parent reply other threads:[~2018-04-16 14:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 13:54 [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0 Alex Bennée
2018-04-16 14:16 ` Bastian Koppelmann
2018-04-16 14:42 ` Alex Bennée [this message]
2018-04-16 14:45 ` Peter Maydell
2018-04-16 19:39 ` Richard Henderson
2018-04-17 8:56 ` Peter Maydell
2018-04-17 8:57 ` Peter Maydell
2018-04-17 19:04 ` Emilio G. Cota
2018-04-17 20:54 ` Peter Maydell
2018-04-17 21:27 ` Emilio G. Cota
2018-04-17 21:45 ` Peter Maydell
2018-04-17 22:38 ` Emilio G. Cota
2018-04-17 22:49 ` Richard Henderson
2018-04-17 23:01 ` Peter Maydell
2018-04-17 23:08 ` Peter Maydell
2018-04-19 19:06 ` Richard Henderson
2018-04-19 19:12 ` Richard Henderson
2018-04-19 19:23 ` Peter Maydell
2018-04-20 8:20 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87604rb4b5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.