From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v4 08/13] drm/i915/guc: Implement response handling in send_ct() Date: Mon, 26 Mar 2018 18:35:00 +0300 Message-ID: <87605ig89n.fsf@intel.com> References: <20180323144728.61548-1-michal.wajdeczko@intel.com> <20180323144728.61548-9-michal.wajdeczko@intel.com> <20180326152932.i7g4i52pzxf33njl@mwiniars-main.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86CD36E4CF for ; Mon, 26 Mar 2018 15:34:10 +0000 (UTC) In-Reply-To: <20180326152932.i7g4i52pzxf33njl@mwiniars-main.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?utf-8?Q?Micha=C5=82?= Winiarski , Michal Wajdeczko Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyNiBNYXIgMjAxOCwgTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lA aW50ZWwuY29tPiB3cm90ZToKPiBPbiBGcmksIE1hciAyMywgMjAxOCBhdCAwMjo0NzoyM1BNICsw MDAwLCBNaWNoYWwgV2FqZGVjemtvIHdyb3RlOgo+PiBJbnN0ZWFkIG9mIHJldHVybmluZyBzbWFs bCBkYXRhIGluIHJlc3BvbnNlIHN0YXR1cyBkd29yZCwKPj4gR3VDIG1heSBhcHBlbmQgbG9uZ2Vy IGRhdGEgYXMgcmVzcG9uc2UgbWVzc2FnZSBwYXlsb2FkLgo+PiBJZiBjYWxsZXIgcHJvdmlkZXMg cmVzcG9uc2UgYnVmZmVyLCB3ZSB3aWxsIGNvcHkgcmVjZWl2ZWQKPj4gZGF0YSBhbmQgdXNlIG51 bWJlciBvZiByZWNlaXZlZCBkYXRhIGR3b3JkcyBhcyBuZXcgc3VjY2Vzcwo+PiByZXR1cm4gdmFs dWUuIFdlIHdpbGwgV0FSTiBpZiByZXNwb25zZSBmcm9tIEd1QyBkb2VzIG5vdAo+PiBtYXRjaCBj YWxsZXIgZXhwZWN0YXRpb24uCj4+IAo+PiB2MjogZml4IHRpbWVvdXQgYW5kIGNoZWNrcGF0Y2gg d2FybmluZ3MgKE1pY2hhbCkKPj4gCj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBXYWpkZWN6a28g PG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+PiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1h dGVvQGludGVsLmNvbT4KPj4gQ2M6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRl bC5jb20+Cj4+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVy aW9AaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19j dC5jIHwgMTM3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmggfCAgIDUgKysKPj4gIDIgZmlsZXMgY2hhbmdl ZCwgMTI4IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+PiAKPgo+IFtTTklQXQo+Cj4+ IEBAIC00MTgsMTMgKzQ5OSwxNSBAQCBzdGF0aWMgaW50IGN0Y2hfc2VuZChzdHJ1Y3QgaW50ZWxf Z3VjICpndWMsCj4+ICBzdGF0aWMgaW50IGludGVsX2d1Y19zZW5kX2N0KHN0cnVjdCBpbnRlbF9n dWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4sCj4+ICAJCQkgICAgIHUzMiAqcmVz cG9uc2VfYnVmLCB1MzIgcmVzcG9uc2VfYnVmX3NpemUpCj4+ICB7Cj4+IC0Jc3RydWN0IGludGVs X2d1Y19jdF9jaGFubmVsICpjdGNoID0gJmd1Yy0+Y3QuaG9zdF9jaGFubmVsOwo+PiArCXN0cnVj dCBpbnRlbF9ndWNfY3QgKmN0ID0gJmd1Yy0+Y3Q7Cj4+ICsJc3RydWN0IGludGVsX2d1Y19jdF9j aGFubmVsICpjdGNoID0gJmN0LT5ob3N0X2NoYW5uZWw7Cj4+ICAJdTMyIHN0YXR1cyA9IH4wOyAv KiB1bmRlZmluZWQgKi8KPj4gIAlpbnQgcmV0Owo+PiAgCj4+ICAJbXV0ZXhfbG9jaygmZ3VjLT5z ZW5kX211dGV4KTsKPj4gIAo+PiAtCXJldCA9IGN0Y2hfc2VuZChndWMsIGN0Y2gsIGFjdGlvbiwg bGVuLCAmc3RhdHVzKTsKPj4gKwlyZXQgPSBjdGNoX3NlbmQoY3QsIGN0Y2gsIGFjdGlvbiwgbGVu LCByZXNwb25zZV9idWYsIHJlc3BvbnNlX2J1Zl9zaXplLAo+PiArCQkJJnN0YXR1cyk7Cj4+ICAJ aWYgKHVubGlrZWx5KHJldCA8IDApKSB7Cj4+ICAJCURSTV9FUlJPUigiQ1Q6IHNlbmQgYWN0aW9u ICUjWCBmYWlsZWQ7IGVycj0lZCBzdGF0dXM9JSNYXG4iLAo+PiAgCQkJICBhY3Rpb25bMF0sIHJl dCwgc3RhdHVzKTsKPj4gQEAgLTUwMyw4ICs1ODYsMTMgQEAgc3RhdGljIGludCBjdGJfcmVhZChz dHJ1Y3QgaW50ZWxfZ3VjX2N0X2J1ZmZlciAqY3RiLCB1MzIgKmRhdGEpCj4+ICBzdGF0aWMgaW50 IGN0X2hhbmRsZV9yZXNwb25zZShzdHJ1Y3QgaW50ZWxfZ3VjX2N0ICpjdCwgY29uc3QgdTMyICpt c2cpCj4+ICB7Cj4+ICAJdTMyIGhlYWRlciA9IG1zZ1swXTsKPj4gKwl1MzIgZmVuY2UgPSBtc2db MV07Cj4+ICAJdTMyIHN0YXR1cyA9IG1zZ1syXTsKPj4gIAl1MzIgbGVuID0gY3RfaGVhZGVyX2dl dF9sZW4oaGVhZGVyKSArIDE7IC8qIHRvdGFsIGxlbiB3aXRoIGhlYWRlciAqLwo+PiArCXUzMiBw YXlsb2FkX2xlbiA9IGxlbiAtIDM7IC8qIGxlbjwzIGlzIHRyZWF0ZWQgYXMgcHJvdG9jb2wgZXJy b3IgKi8KPgo+IE1hZ2ljIG51bWJlcnMsIHBsZWFzZSBldGhlciBkZWZpbmUgMyBhcyBtaW4gcGF5 bG9hZCBsZW5ndGggb3IgaGlkZSB0aGlzIGJlaGluZAo+IG1hY3JvLgoKQW5kIGNoZWNrIGxlbiA+ PSAzIGJlZm9yZSBzdWJzdHJhY3RpbmcgMy4KCkJSLApKYW5pLgoKCj4KPj4gKwlzdHJ1Y3QgY3Rf cmVxdWVzdCAqcmVxOwo+PiArCWJvb2wgZm91bmQgPSBmYWxzZTsKPj4gKwl1bnNpZ25lZCBsb25n IGZsYWdzOwo+PiAgCj4+ICAJR0VNX0JVR19PTighY3RfaGVhZGVyX2lzX3Jlc3BvbnNlKGhlYWRl cikpOwo+PiAgCj4+IEBAIC01MTgsOCArNjA2LDI5IEBAIHN0YXRpYyBpbnQgY3RfaGFuZGxlX3Jl c3BvbnNlKHN0cnVjdCBpbnRlbF9ndWNfY3QgKmN0LCBjb25zdCB1MzIgKm1zZykKPj4gIAkJRFJN X0VSUk9SKCJDVDogY29ycnVwdGVkIHJlc3BvbnNlICUqcGhuXG4iLCA0KmxlbiwgbXNnKTsKPj4g IAkJcmV0dXJuIC1FUFJPVE87Cj4+ICAJfQo+PiArCXNwaW5fbG9ja19pcnFzYXZlKCZjdC0+bG9j aywgZmxhZ3MpOwo+Cj4gSXNuJ3QgdGhpcyBjYWxsZWQgZnJvbSB0aGUgaXJxPyBXZSBjYW4gdXNl IHBsYWluIHNwaW5fbG9jayBoZXJlLgo+Cj4+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZj dC0+cGVuZGluZ19yZXF1ZXN0cywgbGluaykgewo+PiArCQlpZiAocmVxLT5mZW5jZSAhPSBmZW5j ZSkgewo+PiArCQkJRFJNX0RFQlVHX0RSSVZFUigiQ1Q6IHJlcXVlc3QgJXUgYXdhaXRzIHJlc3Bv bnNlXG4iLAo+PiArCQkJCQkgcmVxLT5mZW5jZSk7Cj4+ICsJCQljb250aW51ZTsKPgo+IElzIHRo aXMgZXhwZWN0ZWQ/Cj4gSW4gb3RoZXIgd29yZHMgLSBkbyB3ZSBleHBlY3Qgb3V0IG9mIG9yZGVy IHJlc3BvbnNlcz8KPiBDYW4gd2UgZXh0cmFjdCB0aGlzIGludG8gYSBoZWxwZXIgKGZpbmQgcmVx dWVzdCk/Cj4KPiAtTWljaGHFggo+Cj4+ICsJCX0KPj4gKwkJaWYgKHVubGlrZWx5KHBheWxvYWRf bGVuID4gcmVxLT5yZXNwb25zZV9sZW4pKSB7Cj4+ICsJCQlEUk1fRVJST1IoIkNUOiByZXNwb25z ZSAldSB0b28gbG9uZyAlKnBoblxuIiwKPj4gKwkJCQkgIHJlcS0+ZmVuY2UsIDQqbGVuLCBtc2cp Owo+PiArCQkJcGF5bG9hZF9sZW4gPSAwOwo+PiArCQl9Cj4+ICsJCWlmIChwYXlsb2FkX2xlbikK Pj4gKwkJCW1lbWNweShyZXEtPnJlc3BvbnNlX2J1ZiwgbXNnICsgMywgNCpwYXlsb2FkX2xlbik7 Cj4+ICsJCXJlcS0+cmVzcG9uc2VfbGVuID0gcGF5bG9hZF9sZW47Cj4+ICsJCVdSSVRFX09OQ0Uo cmVxLT5zdGF0dXMsIHN0YXR1cyk7Cj4+ICsJCWZvdW5kID0gdHJ1ZTsKPj4gKwkJYnJlYWs7Cj4+ ICsJfQo+PiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmN0LT5sb2NrLCBmbGFncyk7Cj4+ICAK Pj4gLQkvKiBYWFggKi8KPj4gKwlpZiAoIWZvdW5kKQo+PiArCQlEUk1fRVJST1IoIkNUOiB1bnNv bGljaXRlZCByZXNwb25zZSAlKnBoblxuIiwgNCpsZW4sIG1zZyk7Cj4+ICAJcmV0dXJuIDA7Cj4+ ICB9Cj4+ICAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19j dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmgKPj4gaW5kZXggNTk1Yzhh ZC4uOTA1NTY2YiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj X2N0LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmgKPj4gQEAg LTcxLDEwICs3MSwxNSBAQCBzdHJ1Y3QgaW50ZWxfZ3VjX2N0X2NoYW5uZWwgewo+PiAgLyoqIEhv bGRzIGFsbCBjb21tYW5kIHRyYW5zcG9ydCBjaGFubmVscy4KPj4gICAqCj4+ICAgKiBAaG9zdF9j aGFubmVsOiBtYWluIGNoYW5uZWwgdXNlZCBieSB0aGUgaG9zdAo+PiArICogQGxvY2s6IHNwaW4g bG9jayBmb3IgcGVuZGluZyByZXF1ZXN0cyBsaXN0Cj4+ICsgKiBAcGVuZGluZ19yZXF1ZXN0czog bGlzdCBvZiBwZW5kaW5nIHJlcXVlc3RzCj4+ICAgKi8KPj4gIHN0cnVjdCBpbnRlbF9ndWNfY3Qg ewo+PiAgCXN0cnVjdCBpbnRlbF9ndWNfY3RfY2hhbm5lbCBob3N0X2NoYW5uZWw7Cj4+ICAJLyog b3RoZXIgY2hhbm5lbHMgYXJlIHRiZCAqLwo+PiArCj4+ICsJc3BpbmxvY2tfdCBsb2NrOwo+PiAr CXN0cnVjdCBsaXN0X2hlYWQgcGVuZGluZ19yZXF1ZXN0czsKPj4gIH07Cj4+ICAKPj4gIHZvaWQg aW50ZWxfZ3VjX2N0X2luaXRfZWFybHkoc3RydWN0IGludGVsX2d1Y19jdCAqY3QpOwo+PiAtLSAK Pj4gMS45LjEKPj4gCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK