From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Always update the no_fbc_reason when disabling Date: Mon, 05 Feb 2018 13:05:09 +0200 Message-ID: <87607bbst6.fsf@intel.com> References: <20180125224122.27480-1-chris@chris-wilson.co.uk> <151765284595.15322.5728680140468949585@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 845846E095 for ; Mon, 5 Feb 2018 11:05:19 +0000 (UTC) In-Reply-To: <151765284595.15322.5728680140468949585@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCAwMyBGZWIgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgQ2hyaXMgV2lsc29uICgyMDE4LTAxLTI1IDIyOjQxOjIyKQo+ PiBQcm92aWRlIHRoZSByZWFzb24gd2h5IHdlIGNhbGwgaW50ZWxfZmJjX2RlYWN0aXZhdGUoKSBz byB0aGF0IGRlYnVnZ2luZwo+PiBpc3N1ZXMgd2l0aCBGQkMgYmVpbmcgZGVsYXllZCBpcyBjbGVh cmVyLgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4KPiBBbnkgdGFrZXJzPwoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+CgoKPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2ZiYy5jIHwgMTcgKysrKysrKysrKy0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJj LmMKPj4gaW5kZXggYThhOGE4MDQ5N2E4Li44MDY4MmE0MThhNzAgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2ZiYy5jCj4+IEBAIC00OTIsNyArNDkyLDggQEAgc3RhdGljIHZvaWQgaW50ZWxf ZmJjX3NjaGVkdWxlX2FjdGl2YXRpb24oc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4+ICAgICAg ICAgc2NoZWR1bGVfd29yaygmd29yay0+d29yayk7Cj4+ICB9Cj4+ICAKPj4gLXN0YXRpYyB2b2lk IGludGVsX2ZiY19kZWFjdGl2YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK Pj4gK3N0YXRpYyB2b2lkIGludGVsX2ZiY19kZWFjdGl2YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg Y2hhciAqcmVhc29uKQo+PiAgewo+PiAgICAgICAgIHN0cnVjdCBpbnRlbF9mYmMgKmZiYyA9ICZk ZXZfcHJpdi0+ZmJjOwo+PiAgCj4+IEBAIC01MDUsNiArNTA2LDggQEAgc3RhdGljIHZvaWQgaW50 ZWxfZmJjX2RlYWN0aXZhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAg Cj4+ICAgICAgICAgaWYgKGZiYy0+YWN0aXZlKQo+PiAgICAgICAgICAgICAgICAgaW50ZWxfZmJj X2h3X2RlYWN0aXZhdGUoZGV2X3ByaXYpOwo+PiArCj4+ICsgICAgICAgZmJjLT5ub19mYmNfcmVh c29uID0gcmVhc29uOwo+PiAgfQo+PiAgCj4+ICBzdGF0aWMgYm9vbCBtdWx0aXBsZV9waXBlc19v ayhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gQEAgLTkyMyw2ICs5MjYsNyBAQCB2b2lkIGlu dGVsX2ZiY19wcmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+PiAgewo+PiAgICAg ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFz ZS5kZXYpOwo+PiAgICAgICAgIHN0cnVjdCBpbnRlbF9mYmMgKmZiYyA9ICZkZXZfcHJpdi0+ZmJj Owo+PiArICAgICAgIGNvbnN0IGNoYXIgKnJlYXNvbiA9ICJ1cGRhdGUgcGVuZGluZyI7Cj4+ICAK Pj4gICAgICAgICBpZiAoIWZiY19zdXBwb3J0ZWQoZGV2X3ByaXYpKQo+PiAgICAgICAgICAgICAg ICAgcmV0dXJuOwo+PiBAQCAtOTMwLDcgKzkzNCw3IEBAIHZvaWQgaW50ZWxfZmJjX3ByZV91cGRh dGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4+ICAgICAgICAgbXV0ZXhfbG9jaygmZmJjLT5s b2NrKTsKPj4gIAo+PiAgICAgICAgIGlmICghbXVsdGlwbGVfcGlwZXNfb2soY3J0YywgcGxhbmVf c3RhdGUpKSB7Cj4+IC0gICAgICAgICAgICAgICBmYmMtPm5vX2ZiY19yZWFzb24gPSAibW9yZSB0 aGFuIG9uZSBwaXBlIGFjdGl2ZSI7Cj4+ICsgICAgICAgICAgICAgICByZWFzb24gPSAibW9yZSB0 aGFuIG9uZSBwaXBlIGFjdGl2ZSI7Cj4+ICAgICAgICAgICAgICAgICBnb3RvIGRlYWN0aXZhdGU7 Cj4+ICAgICAgICAgfQo+PiAgCj4+IEBAIC05NDAsNyArOTQ0LDcgQEAgdm9pZCBpbnRlbF9mYmNf cHJlX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gICAgICAgICBpbnRlbF9mYmNf dXBkYXRlX3N0YXRlX2NhY2hlKGNydGMsIGNydGNfc3RhdGUsIHBsYW5lX3N0YXRlKTsKPj4gIAo+ PiAgZGVhY3RpdmF0ZToKPj4gLSAgICAgICBpbnRlbF9mYmNfZGVhY3RpdmF0ZShkZXZfcHJpdik7 Cj4+ICsgICAgICAgaW50ZWxfZmJjX2RlYWN0aXZhdGUoZGV2X3ByaXYsIHJlYXNvbik7Cj4+ICB1 bmxvY2s6Cj4+ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZmYmMtPmxvY2spOwo+PiAgfQo+PiBAQCAt OTczLDkgKzk3Nyw4IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfZmJjX3Bvc3RfdXBkYXRlKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKQo+PiAgICAgICAgICAgICBpbnRlbF9mYmNfcmVnX3BhcmFtc19l cXVhbCgmb2xkX3BhcmFtcywgJmZiYy0+cGFyYW1zKSkKPj4gICAgICAgICAgICAgICAgIHJldHVy bjsKPj4gIAo+PiAtICAgICAgIGludGVsX2ZiY19kZWFjdGl2YXRlKGRldl9wcml2KTsKPj4gKyAg ICAgICBpbnRlbF9mYmNfZGVhY3RpdmF0ZShkZXZfcHJpdiwgIkZCQyBlbmFibGVkIChhY3RpdmUg b3Igc2NoZWR1bGVkKSIpOwo+PiAgICAgICAgIGludGVsX2ZiY19zY2hlZHVsZV9hY3RpdmF0aW9u KGNydGMpOwo+PiAtICAgICAgIGZiYy0+bm9fZmJjX3JlYXNvbiA9ICJGQkMgZW5hYmxlZCAoYWN0 aXZlIG9yIHNjaGVkdWxlZCkiOwo+PiAgfQo+PiAgCj4+ICB2b2lkIGludGVsX2ZiY19wb3N0X3Vw ZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4gQEAgLTEwMTYsNyArMTAxOSw3IEBAIHZv aWQgaW50ZWxfZmJjX2ludmFsaWRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+PiAgICAgICAgIGZiYy0+YnVzeV9iaXRzIHw9IGludGVsX2ZiY19nZXRfZnJvbnRidWZmZXJf Yml0KGZiYykgJiBmcm9udGJ1ZmZlcl9iaXRzOwo+PiAgCj4+ICAgICAgICAgaWYgKGZiYy0+ZW5h YmxlZCAmJiBmYmMtPmJ1c3lfYml0cykKPj4gLSAgICAgICAgICAgICAgIGludGVsX2ZiY19kZWFj dGl2YXRlKGRldl9wcml2KTsKPj4gKyAgICAgICAgICAgICAgIGludGVsX2ZiY19kZWFjdGl2YXRl KGRldl9wcml2LCAiZnJvbnRidWZmZXIgd3JpdGUiKTsKPj4gIAo+PiAgICAgICAgIG11dGV4X3Vu bG9jaygmZmJjLT5sb2NrKTsKPj4gIH0KPj4gQEAgLTEyNDYsNyArMTI0OSw3IEBAIHN0YXRpYyB2 b2lkIGludGVsX2ZiY191bmRlcnJ1bl93b3JrX2ZuKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykK Pj4gICAgICAgICBEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgRkJDIGR1ZSB0byBGSUZPIHVuZGVy cnVuLlxuIik7Cj4+ICAgICAgICAgZmJjLT51bmRlcnJ1bl9kZXRlY3RlZCA9IHRydWU7Cj4+ICAK Pj4gLSAgICAgICBpbnRlbF9mYmNfZGVhY3RpdmF0ZShkZXZfcHJpdik7Cj4+ICsgICAgICAgaW50 ZWxfZmJjX2RlYWN0aXZhdGUoZGV2X3ByaXYsICJGSUZPIHVuZGVycnVuIik7Cj4+ICBvdXQ6Cj4+ ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZmYmMtPmxvY2spOwo+PiAgfQo+PiAtLSAKPj4gMi4xNS4x Cj4+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK