From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values Date: Tue, 30 Jan 2018 17:31:59 +0200 Message-ID: <87607jwefk.fsf@intel.com> References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> <20180130151946.GC5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABE7C6E7C8 for ; Tue, 30 Jan 2018 15:32:10 +0000 (UTC) In-Reply-To: <20180130151946.GC5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= , Sean Paul Cc: "Gustavo A. R. Silva" , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAzMCBKYW4gMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMTA6MDk6MjdBTSAt MDUwMCwgU2VhbiBQYXVsIHdyb3RlOgo+PiBPbiBUdWUsIEphbiAzMCwgMjAxOCBhdCAwNDowNToy OEFNIC0wNjAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdyb3RlOgo+PiA+IEFzc2lnbiB0cnVlIG9y IGZhbHNlIHRvIGJvb2xlYW4gdmFyaWFibGVzIGluc3RlYWQgb2YgYW4gaW50ZWdlciB2YWx1ZS4K Pj4gPiAKPj4gPiBUaGlzIGlzc3VlIHdhcyBkZXRlY3RlZCB3aXRoIHRoZSBoZWxwIG9mIENvY2Np bmVsbGUuCj4+IAo+PiBJIHN1cHBvc2UgeW91IGNvdWxkIGFsc28gZml4IHVwIHRoZSBvdGhlciBw cmVmZXJyZWQgYXNzaWdubWVudCBieSBhZGRpbmcgISEKPj4gdG8gdGhlIGJpdHdpc2UgJiBvcGVy YXRpb24uCj4KPiBBc3NpZ25pbmcgPjEgdG8gYSBib29sIGlzIHdlbGwgZGVmaW5lZC4gTm8gbmVl ZCB0byBjbHV0dGVyIHRoZSBjb2RlIHdpdGgKPiAhISBpbW8uCgpBZ3JlZWQuCgpCUiwKSmFuaS4K Cj4KPj4gCj4+IEl0J3MgYWxzbyBoZWxwZnVsIHRvIHBvc3QgdGhlIHNwYXRjaCBpbiB0aGUgY29t bWl0IG1lc3NhZ2Ugc28gb3RoZXJzIGNhbgo+PiByZXBsaWNhdGUgeW91ciByZXN1bHQgKHRoaXMg Y2FzZSBpcyBwcmV0dHkgdHJpdmlhbCwgc28gbGVzcyBpbXBvcnRhbnQpLgo+PiAKPj4gU2Vhbgo+ PiAKPj4gPiAKPj4gPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZv QGVtYmVkZGVkb3IuY29tPgo+PiA+IC0tLQo+PiA+IENoYW5nZXMgaW4gdjI6Cj4+ID4gIC0gVXNl IHRydWUgZm9yIGJvb2xlYW4gdmFsdWUgaW4gYWRkX2RldGFpbGVkX21vZGUgYXMgc3VnZ2VzdGVk IGJ5IERhbmllbAo+PiA+ICAgIFZldHRlci4KPj4gPiAgLSBVcGRhdGUgc3ViamVjdC4KPj4gPiAK Pj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgfCA0ICsrLS0KPj4gPiAgMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4gPiAKPj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Vk aWQuYwo+PiA+IGluZGV4IGRkZDUzNzkuLmIxY2IyNjIgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9lZGlkLmMKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu Ywo+PiA+IEBAIC0yNzY3LDcgKzI3NjcsNyBAQCBkb19kZXRhaWxlZF9tb2RlKHN0cnVjdCBkZXRh aWxlZF90aW1pbmcgKnRpbWluZywgdm9pZCAqYykKPj4gPiAgCj4+ID4gIAkJZHJtX21vZGVfcHJv YmVkX2FkZChjbG9zdXJlLT5jb25uZWN0b3IsIG5ld21vZGUpOwo+PiA+ICAJCWNsb3N1cmUtPm1v ZGVzKys7Cj4+ID4gLQkJY2xvc3VyZS0+cHJlZmVycmVkID0gMDsKPj4gPiArCQljbG9zdXJlLT5w cmVmZXJyZWQgPSBmYWxzZTsKPj4gPiAgCX0KPj4gPiAgfQo+PiA+ICAKPj4gPiBAQCAtMjc4NCw3 ICsyNzg0LDcgQEAgYWRkX2RldGFpbGVkX21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IsIHN0cnVjdCBlZGlkICplZGlkLAo+PiA+ICAJc3RydWN0IGRldGFpbGVkX21vZGVfY2xv c3VyZSBjbG9zdXJlID0gewo+PiA+ICAJCS5jb25uZWN0b3IgPSBjb25uZWN0b3IsCj4+ID4gIAkJ LmVkaWQgPSBlZGlkLAo+PiA+IC0JCS5wcmVmZXJyZWQgPSAxLAo+PiA+ICsJCS5wcmVmZXJyZWQg PSB0cnVlLAo+PiA+ICAJCS5xdWlya3MgPSBxdWlya3MsCj4+ID4gIAl9Owo+PiA+ICAKPj4gPiAt LSAKPj4gPiAyLjcuNAo+PiA+IAo+PiAKPj4gLS0gCj4+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5n aW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPj4gZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbeA3PcM convert rfc822-to-8bit (ORCPT ); Tue, 30 Jan 2018 10:32:12 -0500 Received: from mga01.intel.com ([192.55.52.88]:61264 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbeA3PcL (ORCPT ); Tue, 30 Jan 2018 10:32:11 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,435,1511856000"; d="scan'208";a="26655597" From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= , Sean Paul Cc: "Gustavo A. R. Silva" , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , Daniel Vetter Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values In-Reply-To: <20180130151946.GC5453@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> <20180130151946.GC5453@intel.com> Date: Tue, 30 Jan 2018 17:31:59 +0200 Message-ID: <87607jwefk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jan 2018, Ville Syrjälä wrote: > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: >> On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: >> > Assign true or false to boolean variables instead of an integer value. >> > >> > This issue was detected with the help of Coccinelle. >> >> I suppose you could also fix up the other preferred assignment by adding !! >> to the bitwise & operation. > > Assigning >1 to a bool is well defined. No need to clutter the code with > !! imo. Agreed. BR, Jani. > >> >> It's also helpful to post the spatch in the commit message so others can >> replicate your result (this case is pretty trivial, so less important). >> >> Sean >> >> > >> > Signed-off-by: Gustavo A. R. Silva >> > --- >> > Changes in v2: >> > - Use true for boolean value in add_detailed_mode as suggested by Daniel >> > Vetter. >> > - Update subject. >> > >> > drivers/gpu/drm/drm_edid.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> > index ddd5379..b1cb262 100644 >> > --- a/drivers/gpu/drm/drm_edid.c >> > +++ b/drivers/gpu/drm/drm_edid.c >> > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) >> > >> > drm_mode_probed_add(closure->connector, newmode); >> > closure->modes++; >> > - closure->preferred = 0; >> > + closure->preferred = false; >> > } >> > } >> > >> > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, >> > struct detailed_mode_closure closure = { >> > .connector = connector, >> > .edid = edid, >> > - .preferred = 1, >> > + .preferred = true, >> > .quirks = quirks, >> > }; >> > >> > -- >> > 2.7.4 >> > >> >> -- >> Sean Paul, Software Engineer, Google / Chromium OS >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center