From: Kalle Valo <kvalo@codeaurora.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Andrey Konovalov <andreyknvl@google.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kostya Serebryany <kcc@google.com>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index
Date: Mon, 16 Oct 2017 13:27:43 +0300 [thread overview]
Message-ID: <8760bfo09s.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACT4Y+YLM-u7bMfRB=eu_pz1M9iDrY-Qmnho7Hw_Lh3M=LSeMQ@mail.gmail.com> (Dmitry Vyukov's message of "Sat, 14 Oct 2017 16:38:03 +0200")
Dmitry Vyukov <dvyukov@google.com> writes:
> On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
>> Hi
>>
>> On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote:
>>> I've got the following report while fuzzing the kernel with syzkaller.
>>>
>>> On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4).
>>>
>>> I'm not sure whether this is a bug in the driver, or just a way to
>>> report misbehaving device. In the latter case this shouldn't be a
>>> WARN() call, since WARN() means bug in the kernel.
>>
>> This is about wrong EEPROM, which reported 3 tx streams on
>> non 3 antenna device. I think WARN() is justified and thanks
>> to the call trace I was actually able to to understand what
>> happened.
>>
>> In general I do not think WARN() only means a kernel bug, it
>> can be F/W or H/W bug too.
>
> Hi Stanislaw,
>
> Printing messages is fine. Printing stacks is fine. Just please make
> them distinguishable from kernel bugs and don't kill the whole
> possibility of automated Linux kernel testing. That's an important
> capability.
Not really following you. Are you saying that using WARN() prevents
automated Linux kernel testing?
--
Kalle Valo
next prev parent reply other threads:[~2017-10-16 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 17:50 usb/net/rt2x00: warning in rt2800_eeprom_word_index Andrey Konovalov
2017-10-12 7:25 ` Stanislaw Gruszka
2017-10-14 14:38 ` Dmitry Vyukov
2017-10-16 9:40 ` Stanislaw Gruszka
2017-10-16 12:19 ` Dmitry Vyukov
2017-10-19 8:25 ` Dmitry Vyukov
2017-10-16 10:27 ` Kalle Valo [this message]
2017-10-16 12:16 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760bfo09s.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=helmut.schaa@googlemail.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.