All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl
@ 2017-08-09 10:13 Chris Wilson
  2017-08-09 10:58 ` Mika Kuoppala
  2017-08-09 12:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2017-08-09 10:13 UTC (permalink / raw)
  To: intel-gfx

==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
==24749==    at 0x6A8ADC7: ioctl (syscall-template.S:84)
==24749==    by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
==24749==    by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
==24749==    by 0x112937: set_dpms (kms_flip.c:263)
==24749==    by 0x112937: run_test_step (kms_flip.c:776)
==24749==    by 0x112937: event_loop (kms_flip.c:1138)
==24749==    by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
==24749==    by 0x115468: run_test (kms_flip.c:1450)
==24749==    by 0x1111CF: main (kms_flip.c:1673)
==24749==  Address 0x1ffefff2a0 is on thread 1's stack
==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_kms.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 9fe800d1..0c6dbf74 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1014,11 +1014,10 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
 	bool found_it = false;
 
 	for (i = 0; i < connector->count_props; i++) {
-		struct drm_mode_get_property prop;
+		struct drm_mode_get_property prop = {
+			.prop_id = connector->props[i],
+		};
 
-		prop.prop_id = connector->props[i];
-		prop.count_values = 0;
-		prop.count_enum_blobs = 0;
 		if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
 			continue;
 
-- 
2.13.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl
  2017-08-09 10:13 [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl Chris Wilson
@ 2017-08-09 10:58 ` Mika Kuoppala
  2017-08-09 12:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Mika Kuoppala @ 2017-08-09 10:58 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Chris Wilson <chris@chris-wilson.co.uk> writes:

> ==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
> ==24749==    at 0x6A8ADC7: ioctl (syscall-template.S:84)
> ==24749==    by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
> ==24749==    by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
> ==24749==    by 0x112937: set_dpms (kms_flip.c:263)
> ==24749==    by 0x112937: run_test_step (kms_flip.c:776)
> ==24749==    by 0x112937: event_loop (kms_flip.c:1138)
> ==24749==    by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
> ==24749==    by 0x115468: run_test (kms_flip.c:1450)
> ==24749==    by 0x1111CF: main (kms_flip.c:1673)
> ==24749==  Address 0x1ffefff2a0 is on thread 1's stack
> ==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> ---
>  lib/igt_kms.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 9fe800d1..0c6dbf74 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1014,11 +1014,10 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
>  	bool found_it = false;
>  
>  	for (i = 0; i < connector->count_props; i++) {
> -		struct drm_mode_get_property prop;
> +		struct drm_mode_get_property prop = {
> +			.prop_id = connector->props[i],
> +		};
>  
> -		prop.prop_id = connector->props[i];
> -		prop.count_values = 0;
> -		prop.count_enum_blobs = 0;
>  		if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
>  			continue;
>  
> -- 
> 2.13.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for lib/kms: Clear unused fields for getproperty ioctl
  2017-08-09 10:13 [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl Chris Wilson
  2017-08-09 10:58 ` Mika Kuoppala
@ 2017-08-09 12:37 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-08-09 12:37 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: lib/kms: Clear unused fields for getproperty ioctl
URL   : https://patchwork.freedesktop.org/series/28546/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build
c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.

with latest DRM-Tip kernel build CI_DRM_2938
6da5aacea58f drm-tip: 2017y-08m-09d-10h-44m-50s UTC integration manifest

Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-snb-2600) fdo#100215
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                skip       -> PASS       (fi-skl-x1585l) fdo#101781
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-c-frame-sequence:
                pass       -> INCOMPLETE (fi-bxt-j4205)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-byt-n2820) fdo#101705

fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:434s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:416s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:355s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:494s
fi-bxt-j4205     total:229  pass:212  dwarn:0   dfail:0   fail:0   skip:16 
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:520s
fi-byt-n2820     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:582s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:430s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:404s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:421s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:499s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:473s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:460s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:568s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:578s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:522s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:451s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:644s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:459s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:426s
fi-skl-x1585l    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:488s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:547s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:411s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_39/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-09 12:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 10:13 [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl Chris Wilson
2017-08-09 10:58 ` Mika Kuoppala
2017-08-09 12:37 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.