From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result Date: Tue, 18 Jul 2017 10:38:00 +0300 Message-ID: <8760eqb3fr.fsf@intel.com> References: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paul Kocialkowski , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Daniel Vetter , David Airlie List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAxNyBKdWwgMjAxNywgUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tp QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gVGhpcyBhZGRzIHRoZSBjb25uZWN0b3IgbmFtZSB3 aGVuIHByaW50aW5nIGEgZGVidWcgbWVzc2FnZSBhYm91dCB0aGUgRFAKPiBsaW5rIHRyYWluaW5n IHJlc3VsdC4gSXQgaXMgdXNlZnVsIHRvIGZpZ3VyZSBvdXQgd2hhdCBjb25uZWN0b3IgaXMKPiBm YWlsaW5nIHdoZW4gbXVsdGlwbGUgRFAgY29ubmVjdG9ycyBhcmUgdXNlZC4KClBlcmhhcHMgbW9y ZSBjb25zaXN0ZW50IHdvdWxkIGJlIHVzaW5nIGEgcHJlZml4IGxpa2UgdGhpczoKCglEUk1fREVC VUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBibGEgYmxhIGJsYWFcbiIsCiAgICAgICAgCWNvbm5l Y3Rvci0+YmFzZS5iYXNlLmlkLCBjb25uZWN0b3ItPmJhc2UubmFtZSk7CgpCUiwKSmFuaS4KCj4K PiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAbGlu dXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9saW5r X3RyYWluaW5nLmMgfCAxMCArKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBfbGlua190cmFpbmluZy5jCj4gaW5kZXggYjc5YzFjMGU0MDRjLi43NWE0MTFjOTRjZTUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4g QEAgLTMyMSwxMyArMzIxLDE1IEBAIGludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCkKPiAgCWlmICghaW50ZWxfZHBfbGlua190cmFpbmluZ19jaGFubmVs X2VxdWFsaXphdGlvbihpbnRlbF9kcCkpCj4gIAkJZ290byBmYWlsdXJlX2hhbmRsaW5nOwo+ICAK PiAtCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgUGFzc2VkIGF0IExpbmsgUmF0ZSA9ICVk LCBMYW5lIGNvdW50ID0gJWQiLAo+IC0JCSAgICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGludGVs X2RwLT5sYW5lX2NvdW50KTsKPiArCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgUGFzc2Vk IGF0IExpbmsgUmF0ZSA9ICVkLCBMYW5lIGNvdW50ID0gJWQgZm9yIGNvbm5lY3RvciAlcyIsCj4g KwkJICAgICAgaW50ZWxfZHAtPmxpbmtfcmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQsCj4gKwkJ ICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLm5hbWUpOwo+ICAJcmV0dXJuOwo+ICAKPiAgIGZh aWx1cmVfaGFuZGxpbmc6Cj4gLQlEUk1fREVCVUdfS01TKCJMaW5rIFRyYWluaW5nIGZhaWxlZCBh dCBsaW5rIHJhdGUgPSAlZCwgbGFuZSBjb3VudCA9ICVkIiwKPiAtCQkgICAgICBpbnRlbF9kcC0+ bGlua19yYXRlLCBpbnRlbF9kcC0+bGFuZV9jb3VudCk7Cj4gKwlEUk1fREVCVUdfS01TKCJMaW5r IFRyYWluaW5nIGZhaWxlZCBhdCBsaW5rIHJhdGUgPSAlZCwgbGFuZSBjb3VudCA9ICVkIGZvciBj b25uZWN0b3IgJXMiLAo+ICsJCSAgICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGludGVsX2RwLT5s YW5lX2NvdW50LAo+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiAgCWlm ICghaW50ZWxfZHBfZ2V0X2xpbmtfdHJhaW5fZmFsbGJhY2tfdmFsdWVzKGludGVsX2RwLAo+ICAJ CQkJCQkgICAgIGludGVsX2RwLT5saW5rX3JhdGUsCj4gIAkJCQkJCSAgICAgaW50ZWxfZHAtPmxh bmVfY291bnQpKQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751431AbdGRHif (ORCPT ); Tue, 18 Jul 2017 03:38:35 -0400 Received: from mga02.intel.com ([134.134.136.20]:40999 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbdGRHie (ORCPT ); Tue, 18 Jul 2017 03:38:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="879983987" From: Jani Nikula To: Paul Kocialkowski , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Manasi Navare , Daniel Vetter , David Airlie , Paul Kocialkowski Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result In-Reply-To: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> Date: Tue, 18 Jul 2017 10:38:00 +0300 Message-ID: <8760eqb3fr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jul 2017, Paul Kocialkowski wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. Perhaps more consistent would be using a prefix like this: DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", connector->base.base.id, connector->base.name); BR, Jani. > > Signed-off-by: Paul Kocialkowski > --- > drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > index b79c1c0e404c..75a411c94ce5 100644 > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > if (!intel_dp_link_training_channel_equalization(intel_dp)) > goto failure_handling; > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > - intel_dp->link_rate, intel_dp->lane_count); > + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s", > + intel_dp->link_rate, intel_dp->lane_count, > + intel_connector->base.name); > return; > > failure_handling: > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > - intel_dp->link_rate, intel_dp->lane_count); > + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d for connector %s", > + intel_dp->link_rate, intel_dp->lane_count, > + intel_connector->base.name); > if (!intel_dp_get_link_train_fallback_values(intel_dp, > intel_dp->link_rate, > intel_dp->lane_count)) -- Jani Nikula, Intel Open Source Technology Center