From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2
Date: Wed, 12 Jul 2017 17:45:30 +0200 [thread overview]
Message-ID: <8760ex4q1x.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170712145121.GF6020@localhost.localdomain> (Eduardo Habkost's message of "Wed, 12 Jul 2017 11:51:21 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
> On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote:
>> We don't want to carry along old machine types forever. If we are able to
>> remove the pc machines up to 0.13 one day for example, this would allow
>> us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM
>> BARs directly to low memory). Everything up to pc-1.2 is also known to
>> have issues with migration. So let's start with a deprecation message
>> for the old machine types so that the (hopefully) few users of these old
>> systems start switching over to newer machine types instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> I suggest changing "-machine help" too. Today it looks like this:
>
> Supported machines are:
> pc-i440fx-2.9 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.8 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.7 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.6 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.5 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.4 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.3 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.2 Standard PC (i440FX + PIIX, 1996)
> pc Standard PC (i440FX + PIIX, 1996) (alias of pc-i440fx-2.10)
> pc-i440fx-2.10 Standard PC (i440FX + PIIX, 1996) (default)
> pc-i440fx-2.1 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.0 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.7 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.6 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.5 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.4 Standard PC (i440FX + PIIX, 1996)
> pc-1.3 Standard PC (i440FX + PIIX, 1996)
> pc-1.2 Standard PC (i440FX + PIIX, 1996)
> pc-1.1 Standard PC (i440FX + PIIX, 1996)
> pc-1.0 Standard PC (i440FX + PIIX, 1996)
> pc-0.15 Standard PC (i440FX + PIIX, 1996)
> pc-0.14 Standard PC (i440FX + PIIX, 1996)
> pc-0.13 Standard PC (i440FX + PIIX, 1996)
> pc-0.12 Standard PC (i440FX + PIIX, 1996)
> pc-0.11 Standard PC (i440FX + PIIX, 1996)
> pc-0.10 Standard PC (i440FX + PIIX, 1996)
> pc-q35-2.9 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.8 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.7 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.6 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.5 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.4 Standard PC (Q35 + ICH9, 2009)
> q35 Standard PC (Q35 + ICH9, 2009) (alias of pc-q35-2.10)
> pc-q35-2.10 Standard PC (Q35 + ICH9, 2009)
> isapc ISA-only PC
> none empty machine
>
>
> It could be changed to something like this:
>
> Supported machines are:
> pc-i440fx-2.9 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.8 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.7 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.6 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.5 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.4 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.3 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.2 Standard PC (i440FX + PIIX, 1996)
> pc Standard PC (i440FX + PIIX, 1996) (alias of pc-i440fx-2.10)
> pc-i440fx-2.10 Standard PC (i440FX + PIIX, 1996) (default)
> pc-i440fx-2.1 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.0 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.7 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.6 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.5 Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-1.4 Standard PC (i440FX + PIIX, 1996)
> pc-1.3 Standard PC (i440FX + PIIX, 1996)
> pc-q35-2.9 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.8 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.7 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.6 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.5 Standard PC (Q35 + ICH9, 2009)
> pc-q35-2.4 Standard PC (Q35 + ICH9, 2009)
> q35 Standard PC (Q35 + ICH9, 2009) (alias of pc-q35-2.10)
> pc-q35-2.10 Standard PC (Q35 + ICH9, 2009)
> isapc ISA-only PC
> none empty machine
>
> Deprecated machines: pc-1.2, pc-1.1, pc-1.0, pc-0.15, pc-0.14, pc-0.13,
> pc-0.12, pc-0.11, pc-0.10.
I'd add "(deprecated)" to the existing lines instead. Probably simpler
to code, because it's consistent with the existing format.
next prev parent reply other threads:[~2017-07-12 15:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 8:22 [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2 Thomas Huth
2017-07-12 13:31 ` Gerd Hoffmann
2017-07-12 14:51 ` Eduardo Habkost
2017-07-12 15:17 ` Michael S. Tsirkin
2017-07-12 20:15 ` Eduardo Habkost
2017-07-12 20:31 ` Michael S. Tsirkin
2017-07-12 20:56 ` Eduardo Habkost
2017-07-12 22:27 ` Michael S. Tsirkin
2017-07-13 0:23 ` Laszlo Ersek
2017-07-13 0:45 ` Michael S. Tsirkin
2017-07-13 0:47 ` Michael S. Tsirkin
2017-07-13 15:17 ` Eduardo Habkost
2017-07-13 15:34 ` Laszlo Ersek
2017-07-13 22:41 ` Michael S. Tsirkin
2017-07-14 15:40 ` Eduardo Habkost
2017-07-13 15:24 ` Eric Blake
2017-07-12 15:45 ` Markus Armbruster [this message]
2017-07-12 17:48 ` Eduardo Habkost
2017-07-12 15:04 ` Daniel P. Berrange
2017-07-12 16:00 ` Thomas Huth
2017-07-12 16:12 ` Daniel P. Berrange
2017-07-12 16:23 ` Thomas Huth
2017-07-12 16:32 ` Daniel P. Berrange
2017-07-12 16:23 ` Paolo Bonzini
2017-07-12 16:29 ` Daniel P. Berrange
2017-07-12 20:37 ` Eduardo Habkost
2017-07-13 23:14 ` Michael S. Tsirkin
2017-07-14 16:33 ` Eduardo Habkost
2017-07-12 20:26 ` Eduardo Habkost
2017-07-13 0:30 ` Laszlo Ersek
2017-07-13 0:47 ` Michael S. Tsirkin
2017-07-13 1:02 ` Laszlo Ersek
2017-07-13 1:00 ` Michael S. Tsirkin
2017-07-13 15:20 ` Eduardo Habkost
2017-07-13 23:04 ` Michael S. Tsirkin
2017-07-14 5:37 ` Thomas Huth
2017-07-14 9:50 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760ex4q1x.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.