From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Stefan Fritsch" <sf@sfritsch.de>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command
Date: Wed, 07 Jun 2017 09:06:53 +0200 [thread overview]
Message-ID: <8760g846pe.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1378843477.6503332.1496789071735.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Tue, 6 Jun 2017 18:44:31 -0400 (EDT)")
Paolo Bonzini <pbonzini@redhat.com> writes:
>> >> Is there an obvious test that we can enhance to add coverage of the new
>> >> QMP command?
>> >
>> > You could have a new test covering hw/char/serial.c, but I wouldn't let
>> > that hold the patch.
>>
>> Holding patches is pretty much the only leverage I have to get tests for
>> new stuff :)
>>
>> Asking for tests that cover all of serial.c wouldn't be fair. But I am
>> asking for basic test coverage of new QMP commands.
>
> I agree, on the other hand it's not exactly a comparable area. I am planning
> to write a serial qtest for migration as well (which is more complex than this
> QMP command) so I might as well write the test for this new QMP command myself
> to get my feet wet...
I'm willing to take a committment from someone I trust in lieu of actual
tests. Is this one?
next prev parent reply other threads:[~2017-06-07 7:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 8:52 [Qemu-devel] [PATCH] Add chardev-send-break monitor command Stefan Fritsch
2017-06-05 12:24 ` Eric Blake
2017-06-06 14:17 ` Paolo Bonzini
2017-06-06 16:19 ` Markus Armbruster
2017-06-06 19:47 ` Stefan Fritsch
2017-06-06 22:44 ` Paolo Bonzini
2017-06-07 7:06 ` Markus Armbruster [this message]
2017-06-07 7:10 ` Paolo Bonzini
2017-06-08 9:31 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760g846pe.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sf@sfritsch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.