From: Juan Quintela <quintela@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, qemu-block@nongnu.org,
Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Jeff Cody <jcody@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes
Date: Wed, 17 May 2017 13:37:02 +0200 [thread overview]
Message-ID: <8760gzd89t.fsf@secure.mitica> (raw)
In-Reply-To: <20170516204724.1617-9-eblake@redhat.com> (Eric Blake's message of "Tue, 16 May 2017 15:47:20 -0500")
Eric Blake <eblake@redhat.com> wrote:
> Half the callers were already scaling bytes to sectors; the other
> half can eventually be simplified to use byte iteration. Both
> callers were already using the result as a bool, so make that
> explicit. Making the change also makes it easier for a future
> dirty-bitmap patch to offload scaling over to the internal hbitmap.
>
> Remember, asking whether a byte is dirty is effectively asking
> whether the entire granularity containing the byte is dirty, since
> we only track dirtiness by granularity.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-05-17 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 20:47 [Qemu-devel] [PATCH v2 00/12] make dirty-bitmap byte-based Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 01/12] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 02/12] migration: Don't lose errno across aio context changes Eric Blake
2017-06-27 3:15 ` Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 03/12] dirty-bitmap: Drop unused functions Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 04/12] dirty-bitmap: Track size in bytes Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 05/12] dirty-bitmap: Set iterator start by offset, not sector Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 06/12] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 07/12] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes Eric Blake
2017-05-17 11:34 ` Juan Quintela
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes Eric Blake
2017-05-17 11:37 ` Juan Quintela [this message]
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 09/12] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes Eric Blake
2017-05-17 11:59 ` Juan Quintela
2017-05-17 13:40 ` Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 10/12] mirror: Switch mirror_dirty_init() to byte-based iteration Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 11/12] dirty-bitmap: Switch bdrv_set_dirty() to bytes Eric Blake
2017-05-16 20:47 ` [Qemu-devel] [PATCH v2 12/12] dirty-bitmap: Convert internal hbitmap size/granularity Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760gzd89t.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.