From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 05 May 2017 05:51:47 +0000 Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Message-Id: <8760hfyhos.fsf@intel.com> List-Id: References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> <20170504200928.GL24019@nuc-i3427.alporthouse.com> In-Reply-To: <20170504200928.GL24019@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Wilson , SF Markus Elfring Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Daniel Vetter On Thu, 04 May 2017, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Thu, 4 May 2017 13:20:47 +0200 >> >> Some strings which did not contain data format specifications should be put >> into a sequence. Thus use the corresponding function "seq_puts". > > debugfs / seq_file is not performance critical. Familiar idiomatic code is > much preferred over continually switching between seq_printf and seq_puts. > > And don't even start on converting seq_printf / seq_puts to seq_putc... Agreed. I don't want any of the seq_* changes in this series. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Date: Fri, 05 May 2017 08:51:47 +0300 Message-ID: <8760hfyhos.fsf@intel.com> References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> <20170504200928.GL24019@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170504200928.GL24019@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , SF Markus Elfring Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAwNCBNYXkgMjAxNywgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IE9uIFRodSwgTWF5IDA0LCAyMDE3IGF0IDA2OjU0OjE2UE0gKzAyMDAsIFNG IE1hcmt1cyBFbGZyaW5nIHdyb3RlOgo+PiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1 c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+Cj4+IERhdGU6IFRodSwgNCBNYXkgMjAxNyAxMzoyMDo0NyAr MDIwMAo+PiAKPj4gU29tZSBzdHJpbmdzIHdoaWNoIGRpZCBub3QgY29udGFpbiBkYXRhIGZvcm1h dCBzcGVjaWZpY2F0aW9ucyBzaG91bGQgYmUgcHV0Cj4+IGludG8gYSBzZXF1ZW5jZS4gVGh1cyB1 c2UgdGhlIGNvcnJlc3BvbmRpbmcgZnVuY3Rpb24gInNlcV9wdXRzIi4KPgo+IGRlYnVnZnMgLyBz ZXFfZmlsZSBpcyBub3QgcGVyZm9ybWFuY2UgY3JpdGljYWwuIEZhbWlsaWFyIGlkaW9tYXRpYyBj b2RlIGlzCj4gbXVjaCBwcmVmZXJyZWQgb3ZlciBjb250aW51YWxseSBzd2l0Y2hpbmcgYmV0d2Vl biBzZXFfcHJpbnRmIGFuZCBzZXFfcHV0cy4KPgo+IEFuZCBkb24ndCBldmVuIHN0YXJ0IG9uIGNv bnZlcnRpbmcgc2VxX3ByaW50ZiAvIHNlcV9wdXRzIHRvIHNlcV9wdXRjLi4uCgpBZ3JlZWQuIEkg ZG9uJ3Qgd2FudCBhbnkgb2YgdGhlIHNlcV8qIGNoYW5nZXMgaW4gdGhpcyBzZXJpZXMuCgpCUiwK SmFuaS4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755531AbdEEFv6 (ORCPT ); Fri, 5 May 2017 01:51:58 -0400 Received: from mga04.intel.com ([192.55.52.120]:23977 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdEEFv5 (ORCPT ); Fri, 5 May 2017 01:51:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,291,1491289200"; d="scan'208";a="853141202" From: Jani Nikula To: Chris Wilson , SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() In-Reply-To: <20170504200928.GL24019@nuc-i3427.alporthouse.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> <20170504200928.GL24019@nuc-i3427.alporthouse.com> Date: Fri, 05 May 2017 08:51:47 +0300 Message-ID: <8760hfyhos.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 04 May 2017, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Thu, 4 May 2017 13:20:47 +0200 >> >> Some strings which did not contain data format specifications should be put >> into a sequence. Thus use the corresponding function "seq_puts". > > debugfs / seq_file is not performance critical. Familiar idiomatic code is > much preferred over continually switching between seq_printf and seq_puts. > > And don't even start on converting seq_printf / seq_puts to seq_putc... Agreed. I don't want any of the seq_* changes in this series. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center