From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH RESEND v4 2/6] drm/i915: Correctly enable blacklight adjustment via DPCD Date: Wed, 03 May 2017 12:19:24 +0300 Message-ID: <8760hiqov7.fsf@intel.com> References: <20170418234824.157355-1-puthik@chromium.org> <20170418234824.157355-3-puthik@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC1296E2DA for ; Wed, 3 May 2017 09:17:00 +0000 (UTC) In-Reply-To: <20170418234824.157355-3-puthik@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Puthikorn Voravootivat List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxOCBBcHIgMjAxNywgUHV0aGlrb3JuIFZvcmF2b290aXZhdCA8cHV0aGlrQGNocm9t aXVtLm9yZz4gd3JvdGU6Cj4gaW50ZWxfZHBfYXV4X2VuYWJsZV9iYWNrbGlnaHQoKSBhc3N1bWVk IHRoYXQgdGhlIHJlZ2lzdGVyCj4gQkFDS0xJR0hUX0JSSUdIVE5FU1NfQ09OVFJPTF9NT0RFIGNh biBvbmx5IGhhcyB2YWx1ZSAwMQo+IChEUF9FRFBfQkFDS0xJR0hUX0NPTlRST0xfTU9ERV9QUkVT RVQpIHdoZW4gaW5pdGlhbGl6ZS4KPgo+IFRoaXMgcGF0Y2ggZml4ZWQgdGhhdCBieSBoYW5kbGlu ZyBhbGwgY2FzZXMgb2YgdGhhdCByZWdpc3Rlci4KCkZpeGVzIGxpa2UgdGhpcyBzaG91bGQgcHJl Y2VkZSB0aGUgZnVuY3Rpb25hbCBjaGFuZ2VzLCBpLmUuIHRoaXMgc2hvdWxkCmJlIGVhcmxpZXIg aW4gdGhlIHNlcmllcy4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBQdXRoaWtvcm4gVm9yYXZvb3RpdmF0 IDxwdXRoaWtAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcF9hdXhfYmFja2xpZ2h0LmMgfCAyOSArKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jCj4gaW5kZXggNDJm NzNkOWEzY2NmLi5mMDZjODM4MWM3NGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jCj4gQEAgLTEwMSwxNSArMTAxLDMyIEBAIHN0YXRpYyB2 b2lkIGludGVsX2RwX2F1eF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3Ig KmNvbm5lY3RvcikKPiAgewo+ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19p bnRlbF9kcCgmY29ubmVjdG9yLT5lbmNvZGVyLT5iYXNlKTsKPiAgCXVpbnQ4X3QgZHBjZF9idWYg PSAwOwo+ICsJdWludDhfdCBlZHBfYmFja2xpZ2h0X21vZGUgPSAwOwo+ICAKPiAgCXNldF9hdXhf YmFja2xpZ2h0X2VuYWJsZShpbnRlbF9kcCwgdHJ1ZSk7Cj4gIAo+IC0JaWYgKChkcm1fZHBfZHBj ZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwKPiAtCQkJICAgICAgIERQX0VEUF9CQUNLTElHSFRfTU9E RV9TRVRfUkVHSVNURVIsICZkcGNkX2J1ZikgPT0gMSkgJiYKPiAtCSAgICAoKGRwY2RfYnVmICYg RFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfTUFTSykgPT0KPiAtCSAgICAgRFBfRURQX0JB Q0tMSUdIVF9DT05UUk9MX01PREVfUFJFU0VUKSkKPiAtCQlkcm1fZHBfZHBjZF93cml0ZWIoJmlu dGVsX2RwLT5hdXgsIERQX0VEUF9CQUNLTElHSFRfTU9ERV9TRVRfUkVHSVNURVIsCj4gLQkJCQkg ICAoZHBjZF9idWYgfCBEUF9FRFBfQkFDS0xJR0hUX0NPTlRST0xfTU9ERV9EUENEKSk7CgpVZ2gs IHRoYXQncyByZWFsbHkgdG90YWxseSBidXN0ZWQsIHNpbmNlIHRoaXMgYWN0dWFsbHkgZW5hYmxl cyB0aGUKcHJvZHVjdCBtb2RlIGJlY2F1c2UgaXQgZG9lc24ndCBtYXNrIG91dCB0aGUgcHJlc2V0 IGZpcnN0LiBUaGFua3MgZm9yCmZpeGluZyB0aGlzLgoKPiArCWlmICghZHJtX2RwX2RwY2RfcmVh ZGIoJmludGVsX2RwLT5hdXgsCj4gKwkJCSAgICAgICBEUF9FRFBfQkFDS0xJR0hUX01PREVfU0VU X1JFR0lTVEVSLCAmZHBjZF9idWYpKSB7CgpJIGRvbid0IHRoaW5rIHRoZXJlIGFyZSBhbnkgdmFs aWQgc2NlbmFyaW91cyB3aGVyZSB0aGlzIGNhbGwgd291bGQKcmV0dXJuIDAuIGlmICguLi4gIT0g MSkgaXMgdGhlIHJpZ2h0IGNoZWNrLgoKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJZWRwX2Jh Y2tsaWdodF9tb2RlID0gZHBjZF9idWYgJiBEUF9FRFBfQkFDS0xJR0hUX0NPTlRST0xfTU9ERV9N QVNLOwo+ICsKPiArCXN3aXRjaCAoZWRwX2JhY2tsaWdodF9tb2RlKSB7Cj4gKwljYXNlIERQX0VE UF9CQUNLTElHSFRfQ09OVFJPTF9NT0RFX1BXTToKPiArCWNhc2UgRFBfRURQX0JBQ0tMSUdIVF9D T05UUk9MX01PREVfUFJFU0VUOgo+ICsJY2FzZSBEUF9FRFBfQkFDS0xJR0hUX0NPTlRST0xfTU9E RV9QUk9EVUNUOgo+ICsJCWRwY2RfYnVmICY9IH5EUF9FRFBfQkFDS0xJR0hUX0NPTlRST0xfTU9E RV9NQVNLOwo+ICsJCWRwY2RfYnVmIHw9IERQX0VEUF9CQUNLTElHSFRfQ09OVFJPTF9NT0RFX0RQ Q0Q7Cj4gKwkJZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LAo+ICsJCQlEUF9FRFBf QkFDS0xJR0hUX01PREVfU0VUX1JFR0lTVEVSLCBkcGNkX2J1Zik7CgpJIHdvbmRlciBpZiB0aGUg cmlnaHQgb3JkZXIgd291bGQgYmUgdG8gc2V0IHRoZSBtb2RlIGZpcnN0LCBhbmQgY2FsbApzZXRf YXV4X2JhY2tsaWdodF9lbmFibGUoKSBhZnRlciB0aGF0LiBJIGNvdWxkbid0IGZpbmQgYW55dGhp bmcgYWJvdXQKdGhhdCBpbiB0aGUgc3BlYywgYnV0IGd1dCBmZWVsaW5nIHNheXMgdGhhdCB3b3Vs ZCBiZSBiZXR0ZXIuIE5lZWRzIHRvIGJlCmEgc2VwYXJhdGUgY2hhbmdlIHRob3VnaC4KCkJSLApK YW5pLgoKPiArCQlicmVhazsKPiArCj4gKwkvKiBEbyBub3RoaW5nIHdoZW4gaXQgaXMgYWxyZWFk eSBEUENEIG1vZGUgKi8KPiArCWNhc2UgRFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfRFBD RDoKPiArCWRlZmF1bHQ6Cj4gKwkJYnJlYWs7Cj4gKwl9Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lk IGludGVsX2RwX2F1eF9kaXNhYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpj b25uZWN0b3IpCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=