Re: [Qemu-devel] [PATCH 05/26] audio: Remove UINT8

[Juan Quintela <quintela@redhat.com>]

Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Juan,
>
> On 04/25/2017 07:37 PM, Juan Quintela wrote:
>> uint8_t has existed since ..... all this century?
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  hw/audio/fmopl.c |  8 ++++----
>>  hw/audio/fmopl.h | 39 ++++++++++++++++++++-------------------
>>  2 files changed, 24 insertions(+), 23 deletions(-)
>>
>> diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
>> index 282662a..3d14b45 100644
>> --- a/hw/audio/fmopl.c
>> +++ b/hw/audio/fmopl.c
>> @@ -789,8 +789,8 @@ static void OPLWriteReg(FM_OPL *OPL, int r, int v)
>>  			}
>>  			else
>>  			{	/* set IRQ mask ,timer enable*/
>> -				UINT8 st1 = v&1;
>> -				UINT8 st2 = (v>>1)&1;
>> +				uint8_t st1 = v&1;
>> +				uint8_t st2 = (v>>1)&1;
>
> Welcome to stdint! but since you're changing this code please make it
> more readable (at least spaces) so checkpatch don't reject your serie:
>
> ERROR: spaces required around that '&'

checkpatch reject because there are no spaces and there are tabs all
around.  I think that the only sane solution is to run indent on the
whole file, or maintain the "old" format.

Gerd, any prefferences?

Later, Juan.