From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
Date: Wed, 15 Mar 2017 20:17:35 +0100 [thread overview]
Message-ID: <8760jafiy8.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308053312.29243-1-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Wed, 8 Mar 2017 06:33:12 +0100")
Hi Ralph,
On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> Add appropriate properties to devices in the Linksys WRT AC Series for the
> mvneta driver to use hardware buffer management.
>
> Also update "soc" ranges property and set the status of bm and bm-bppi
> to "okay" (SRAM).
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
> arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++-
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++-
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
> index df47bf1..4aac375 100644
> --- a/arch/arm/boot/dts/armada-385-linksys.dtsi
> +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
> @@ -59,7 +59,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>;
>
> internal-regs {
> i2c at 11000 {
> @@ -88,6 +89,9 @@
> ethernet at 70000 {
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -97,6 +101,9 @@
> ethernet at 34000 {
> status = "okay";
> phy-mode = "sgmii";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
Any reason to reuse the same pool than the other port?
As only two ports are used here, then each of them can have use 2 of the
4 availables pools.
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -159,6 +166,10 @@
> status = "okay";
> };
>
> + bm at c8000 {
> + status = "okay";
> + };
> +
> /* USB part of the eSATA/USB 2.0 port */
> usb at 58000 {
> status = "okay";
> @@ -241,6 +252,10 @@
> };
> };
>
> + bm-bppi {
> + status = "okay";
> + };
> +
> pcie-controller {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 3744ba3..b188a4dc 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -71,7 +71,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>;
>
> internal-regs {
>
> @@ -95,6 +96,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -106,6 +110,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
Same question that above.
Gregory
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -186,6 +193,10 @@
> };
> };
>
> + bm at c8000 {
> + status = "okay";
> + };
> +
> nand at d0000 {
> status = "okay";
> num-cs = <1>;
> @@ -259,6 +270,10 @@
> };
> };
> };
> +
> + bm-bppi {
> + status = "okay";
> + };
> };
>
> gpio_keys {
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Ralph Sennhauser
<ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375,
38x,..."
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
Date: Wed, 15 Mar 2017 20:17:35 +0100 [thread overview]
Message-ID: <8760jafiy8.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308053312.29243-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Ralph Sennhauser's message of "Wed, 8 Mar 2017 06:33:12 +0100")
Hi Ralph,
On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Add appropriate properties to devices in the Linksys WRT AC Series for the
> mvneta driver to use hardware buffer management.
>
> Also update "soc" ranges property and set the status of bm and bm-bppi
> to "okay" (SRAM).
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++-
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++-
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
> index df47bf1..4aac375 100644
> --- a/arch/arm/boot/dts/armada-385-linksys.dtsi
> +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
> @@ -59,7 +59,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>;
>
> internal-regs {
> i2c@11000 {
> @@ -88,6 +89,9 @@
> ethernet@70000 {
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -97,6 +101,9 @@
> ethernet@34000 {
> status = "okay";
> phy-mode = "sgmii";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
Any reason to reuse the same pool than the other port?
As only two ports are used here, then each of them can have use 2 of the
4 availables pools.
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -159,6 +166,10 @@
> status = "okay";
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> /* USB part of the eSATA/USB 2.0 port */
> usb@58000 {
> status = "okay";
> @@ -241,6 +252,10 @@
> };
> };
>
> + bm-bppi {
> + status = "okay";
> + };
> +
> pcie-controller {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 3744ba3..b188a4dc 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -71,7 +71,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>;
>
> internal-regs {
>
> @@ -95,6 +96,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -106,6 +110,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
Same question that above.
Gregory
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -186,6 +193,10 @@
> };
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> nand@d0000 {
> status = "okay";
> num-cs = <1>;
> @@ -259,6 +270,10 @@
> };
> };
> };
> +
> + bm-bppi {
> + status = "okay";
> + };
> };
>
> gpio_keys {
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell
Kirkwood and Armada 370, 375, 38x,...),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
Date: Wed, 15 Mar 2017 20:17:35 +0100 [thread overview]
Message-ID: <8760jafiy8.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308053312.29243-1-ralph.sennhauser@gmail.com> (Ralph Sennhauser's message of "Wed, 8 Mar 2017 06:33:12 +0100")
Hi Ralph,
On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> Add appropriate properties to devices in the Linksys WRT AC Series for the
> mvneta driver to use hardware buffer management.
>
> Also update "soc" ranges property and set the status of bm and bm-bppi
> to "okay" (SRAM).
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
> arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++-
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++-
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
> index df47bf1..4aac375 100644
> --- a/arch/arm/boot/dts/armada-385-linksys.dtsi
> +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
> @@ -59,7 +59,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>;
>
> internal-regs {
> i2c@11000 {
> @@ -88,6 +89,9 @@
> ethernet@70000 {
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -97,6 +101,9 @@
> ethernet@34000 {
> status = "okay";
> phy-mode = "sgmii";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
Any reason to reuse the same pool than the other port?
As only two ports are used here, then each of them can have use 2 of the
4 availables pools.
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -159,6 +166,10 @@
> status = "okay";
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> /* USB part of the eSATA/USB 2.0 port */
> usb@58000 {
> status = "okay";
> @@ -241,6 +252,10 @@
> };
> };
>
> + bm-bppi {
> + status = "okay";
> + };
> +
> pcie-controller {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 3744ba3..b188a4dc 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -71,7 +71,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>;
>
> internal-regs {
>
> @@ -95,6 +96,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -106,6 +110,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
Same question that above.
Gregory
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -186,6 +193,10 @@
> };
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> nand@d0000 {
> status = "okay";
> num-cs = <1>;
> @@ -259,6 +270,10 @@
> };
> };
> };
> +
> + bm-bppi {
> + status = "okay";
> + };
> };
>
> gpio_keys {
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-03-15 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 5:33 [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support Ralph Sennhauser
2017-03-08 5:33 ` Ralph Sennhauser
2017-03-08 5:33 ` Ralph Sennhauser
2017-03-15 19:17 ` Gregory CLEMENT [this message]
2017-03-15 19:17 ` Gregory CLEMENT
2017-03-15 19:17 ` Gregory CLEMENT
2017-03-16 5:48 ` Ralph Sennhauser
2017-03-16 5:48 ` Ralph Sennhauser
2017-03-16 5:48 ` Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760jafiy8.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.