Re: [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	"Dong, Chuanxiao" <chuanxiao.dong@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/gvt: add enable_execlists check before enable gvt
Date: Thu, 09 Mar 2017 15:48:29 +0200	[thread overview]
Message-ID: <8760jih87m.fsf@intel.com> (raw)
In-Reply-To: <20170309132311.GA25088@nuc-i3427.alporthouse.com>

On Thu, 09 Mar 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Mar 09, 2017 at 01:03:17PM +0000, Dong, Chuanxiao wrote:
>> The message printed is longer than 80 characters, and checkpatch tool also complain with " quoted string split across lines" by splitting to multiple lines. So should I use the message print like below?
>>                 
>> DRM_INFO("GPU guest virtualisation [GVT-g] disabled due to ");
>> DRM_INFO("disabled execlist submission ");
>> DRM_INFO("[i915.enable_execlists module parameter]\n");
>> 
>> Or any better idea?
>
> Just ignore checkpatch. Either split the line or not, that's up to you :)

Btw ignoring checkpatch is not general advise. Please do always look at
checkpatch results, it does give helpful feedback on silly mistakes. But
just don't regard it as the final authority on kernel style, use your
own discretion. In this case, checkpatch is just silly.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx