From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Wed, 25 Jan 2017 08:55:42 +0100 [thread overview]
Message-ID: <8760l3375t.fsf@free-electrons.com> (raw)
In-Reply-To: <20170125020249.GB24034@lunn.ch> (Andrew Lunn's message of "Wed, 25 Jan 2017 03:02:49 +0100")
Hi Andrew,
On mer., janv. 25 2017, Andrew Lunn <andrew@lunn.ch> wrote:
>> + [MV88E6341] = {
>> + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341,
>> + .family = MV88E6XXX_FAMILY_6341,
>> + .name = "Marvell 88E6341",
>> + .num_databases = 4096,
>> + .num_ports = 6,
>> + .port_base_addr = 0x10,
>> + .global1_addr = 0x1b,
>> + .age_time_coeff = 15000,
>
> Hi Gregory
>
> Please could you check this timer in the datasheet. There is currently
> a bug in the mv88e6390 support code. I also set it to 15s. But in fact
> it is 3.75 seconds. The 6341 might also use 3.75 seconds.
When I read your series I also thought about it and indeed it is 3.75
seconds. I will fix it.
Thanks,
Gregory
>
> Thanks
> Andrew
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Nadav Haklai <nadavh@marvell.com>,
Wilson Ding <dingwei@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Joe Zhou <shjzhou@marvell.com>,
Jon Pannell <jpannell@marvell.com>
Subject: Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Wed, 25 Jan 2017 08:55:42 +0100 [thread overview]
Message-ID: <8760l3375t.fsf@free-electrons.com> (raw)
In-Reply-To: <20170125020249.GB24034@lunn.ch> (Andrew Lunn's message of "Wed, 25 Jan 2017 03:02:49 +0100")
Hi Andrew,
On mer., janv. 25 2017, Andrew Lunn <andrew@lunn.ch> wrote:
>> + [MV88E6341] = {
>> + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341,
>> + .family = MV88E6XXX_FAMILY_6341,
>> + .name = "Marvell 88E6341",
>> + .num_databases = 4096,
>> + .num_ports = 6,
>> + .port_base_addr = 0x10,
>> + .global1_addr = 0x1b,
>> + .age_time_coeff = 15000,
>
> Hi Gregory
>
> Please could you check this timer in the datasheet. There is currently
> a bug in the mv88e6390 support code. I also set it to 15s. But in fact
> it is 3.75 seconds. The 6341 might also use 3.75 seconds.
When I read your series I also thought about it and indeed it is 3.75
seconds. I will fix it.
Thanks,
Gregory
>
> Thanks
> Andrew
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-25 7:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:10 [PATCH net-next v6 0/4] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT
2017-01-24 20:10 ` Gregory CLEMENT
2017-01-24 20:10 ` [PATCH net-next v6 1/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT
2017-01-24 20:10 ` Gregory CLEMENT
2017-01-24 20:31 ` Gregory CLEMENT
2017-01-24 20:31 ` Gregory CLEMENT
2017-01-24 20:10 ` [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT
2017-01-24 20:10 ` Gregory CLEMENT
2017-01-25 2:02 ` Andrew Lunn
2017-01-25 2:02 ` Andrew Lunn
2017-01-25 7:55 ` Gregory CLEMENT [this message]
2017-01-25 7:55 ` Gregory CLEMENT
2017-01-25 18:58 ` Jon Pannell
2017-01-25 18:58 ` Jon Pannell
2017-01-25 18:58 ` Jon Pannell
2017-01-24 20:10 ` [PATCH net-next v6 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6141 Gregory CLEMENT
2017-01-24 20:10 ` Gregory CLEMENT
2017-01-24 20:10 ` [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY embedded in the topaz switch Gregory CLEMENT
2017-01-24 20:10 ` Gregory CLEMENT
2017-01-24 20:28 ` Andrew Lunn
2017-01-24 20:28 ` Andrew Lunn
2017-01-24 20:55 ` Gregory CLEMENT
2017-01-24 20:55 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760l3375t.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.