From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRxC4-0006ET-Tr for qemu-devel@nongnu.org; Fri, 13 Jan 2017 03:26:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRxC1-0006OA-0p for qemu-devel@nongnu.org; Fri, 13 Jan 2017 03:26:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37792) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRxC0-0006Ms-Qs for qemu-devel@nongnu.org; Fri, 13 Jan 2017 03:26:36 -0500 From: Markus Armbruster References: <1484291524-1261-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1484291524-1261-11-git-send-email-caoj.fnst@cn.fujitsu.com> Date: Fri, 13 Jan 2017 09:26:33 +0100 In-Reply-To: <1484291524-1261-11-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao jin's message of "Fri, 13 Jan 2017 15:12:04 +0800") Message-ID: <8760lj2wna.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , "Michael S. Tsirkin" , Hannes Reinecke Cao jin writes: > Also move certain hunk above, to place msix init related code together. > > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > > Signed-off-by: Cao jin > --- > hw/scsi/megasas.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > msix_init() doesn't set the MSI-X enable bit, so use msix_enabled() > is not right here, restore the old check without the > megasas_use_msix() wrapper. Reviewed-by: Markus Armbruster