From: Robert Jarzmik <robert.jarzmik@free.fr>
To: arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@atmel.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [V2] mtd: devices: docg3:- Handle return value of devm_ioremap.
Date: Mon, 12 Dec 2016 17:32:58 +0100 [thread overview]
Message-ID: <8760mp151h.fsf@belgarion.home> (raw)
In-Reply-To: <80fc935a-39aa-eaca-e75c-02078c3dab05@gmail.com> (arvind Yadav's message of "Mon, 12 Dec 2016 21:33:05 +0530")
arvind Yadav <arvind.yadav.cs@gmail.com> writes:
> There is problem, if you will use devm_ioremap_resource instead of devm_ioremap,
> than devm_ioremap_resource will call request_mem_region().
> request_mem_region() allows to tell the kernel that this driver is going to use
> this range of I/O addresses, which will prevent other drivers to make an
> overlapping call to request_mem_region If other driver want to use same address
> space to access then it will not allow. Means we can not share same address
> space
> between two driver.
Hi,
You're right Arvind, and still, it's worth noticing that the docg3 access
semantics imply a "reserved" resource path (see how doc_register_readb() does a
write and how this cannot be shared with another driver).
Therefore I'll be willing to ack a mix of your both patches, the
devm_ioremap_resource() from Boris and the error message from your patch.
Cheers.
--
Robert
next prev parent reply other threads:[~2016-12-12 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 3:00 [V2] mtd: devices: docg3:- Handle return value of devm_ioremap Arvind Yadav
2016-12-12 4:10 ` Marek Vasut
2016-12-12 8:42 ` Boris Brezillon
2016-12-12 16:03 ` arvind Yadav
2016-12-12 16:32 ` Robert Jarzmik [this message]
2016-12-12 17:00 ` Boris Brezillon
2016-12-12 17:04 ` Boris Brezillon
2016-12-12 18:15 ` arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760mp151h.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arvind.yadav.cs@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.