From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1bouHn-0001dF-NK for mharc-qemu-trivial@gnu.org; Tue, 27 Sep 2016 11:27:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bouHk-0001a2-Pk for qemu-trivial@nongnu.org; Tue, 27 Sep 2016 11:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bouHj-0004YD-K8 for qemu-trivial@nongnu.org; Tue, 27 Sep 2016 11:27:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bouHd-0004Ug-R4; Tue, 27 Sep 2016 11:27:01 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B5571293; Tue, 27 Sep 2016 15:27:01 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-56.ams2.redhat.com [10.36.116.56]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8RFQxFn004598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 27 Sep 2016 11:27:00 -0400 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3603D1132B64; Tue, 27 Sep 2016 17:26:59 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-trivial@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org References: <20160923123508.27000-1-marcandre.lureau@redhat.com> <87wphxh1gf.fsf@dusky.pond.sub.org> <227638539.339534.1474986123574.JavaMail.zimbra@redhat.com> Date: Tue, 27 Sep 2016 17:26:59 +0200 In-Reply-To: <227638539.339534.1474986123574.JavaMail.zimbra@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 27 Sep 2016 10:22:03 -0400 (EDT)") Message-ID: <8760phfjng.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 27 Sep 2016 15:27:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] build-sys: fix find-in-path X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 15:27:10 -0000 Marc-Andr=C3=A9 Lureau writes: > Hi > > ----- Original Message ----- >> Marc-Andr=C3=A9 Lureau writes: >>=20 >> > Fix spelling, the GNU make text functions is not called "find-string" >> > but "findstring". >> > >> > Signed-off-by: Marc-Andr=C3=A9 Lureau >> > --- >> > rules.mak | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/rules.mak b/rules.mak >> > index 5c82c19..f721988 100644 >> > --- a/rules.mak >> > +++ b/rules.mak >> > @@ -132,7 +132,7 @@ endef >> > # Looks in the PATH if the argument contains no slash, else only cons= iders >> > one >> > # specific directory. Returns an # empty string if the program doesn= 't >> > exist >> > # there. >> > -find-in-path =3D $(if $(find-string /, $1), \ >> > +find-in-path =3D $(if $(findstring /, $1), \ >> > $(wildcard $1), \ >> > $(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH))))) >>=20 >> Impact? > > Not much in current code base, it's only used by: > tests/tcg/Makefile:ifneq ($(call find-in-path, $(CC_I386)),) > > So if you set CC_I386 to an absolute PATH, it's not going to run the I386= _TESTS. > > This is not very important yet, but better for correctness. > > In the future, I hope qemu can have a better tcg-test framework (I am doi= ng some experiment in https://github.com/elmarco/qemu/tree/tcg-tests/tests/= tcg), and as part of this work, I found this bug. Thanks. Suggest to amend the commit message with: Broken in commit 2b2e59e. Fairly harmless: its only use is in tests/tcg/Makefile, where the bug can cause the I386_TESTS not to run when they should. With this or something similar, you may add Reviewed-by: Markus Armbruster From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bouHi-0001XU-5Q for qemu-devel@nongnu.org; Tue, 27 Sep 2016 11:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bouHe-0004Uq-1W for qemu-devel@nongnu.org; Tue, 27 Sep 2016 11:27:06 -0400 From: Markus Armbruster References: <20160923123508.27000-1-marcandre.lureau@redhat.com> <87wphxh1gf.fsf@dusky.pond.sub.org> <227638539.339534.1474986123574.JavaMail.zimbra@redhat.com> Date: Tue, 27 Sep 2016 17:26:59 +0200 In-Reply-To: <227638539.339534.1474986123574.JavaMail.zimbra@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 27 Sep 2016 10:22:03 -0400 (EDT)") Message-ID: <8760phfjng.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-trivial@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org Marc-Andr=C3=A9 Lureau writes: > Hi > > ----- Original Message ----- >> Marc-Andr=C3=A9 Lureau writes: >>=20 >> > Fix spelling, the GNU make text functions is not called "find-string" >> > but "findstring". >> > >> > Signed-off-by: Marc-Andr=C3=A9 Lureau >> > --- >> > rules.mak | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/rules.mak b/rules.mak >> > index 5c82c19..f721988 100644 >> > --- a/rules.mak >> > +++ b/rules.mak >> > @@ -132,7 +132,7 @@ endef >> > # Looks in the PATH if the argument contains no slash, else only cons= iders >> > one >> > # specific directory. Returns an # empty string if the program doesn= 't >> > exist >> > # there. >> > -find-in-path =3D $(if $(find-string /, $1), \ >> > +find-in-path =3D $(if $(findstring /, $1), \ >> > $(wildcard $1), \ >> > $(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH))))) >>=20 >> Impact? > > Not much in current code base, it's only used by: > tests/tcg/Makefile:ifneq ($(call find-in-path, $(CC_I386)),) > > So if you set CC_I386 to an absolute PATH, it's not going to run the I386= _TESTS. > > This is not very important yet, but better for correctness. > > In the future, I hope qemu can have a better tcg-test framework (I am doi= ng some experiment in https://github.com/elmarco/qemu/tree/tcg-tests/tests/= tcg), and as part of this work, I found this bug. Thanks. Suggest to amend the commit message with: Broken in commit 2b2e59e. Fairly harmless: its only use is in tests/tcg/Makefile, where the bug can cause the I386_TESTS not to run when they should. With this or something similar, you may add Reviewed-by: Markus Armbruster