From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: squash lines for simple wrapper functions Date: Wed, 07 Sep 2016 11:34:44 +0300 Message-ID: <8760q8xg4b.fsf@intel.com> References: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , dri-devel@lists.freedesktop.org Cc: Krzysztof Kozlowski , Masahiro Yamada , Huang Rui , Eric Huang , Daniel Vetter , Flora Cui , Gustavo Padovan , Tom St Denis , Dave Airlie , Dan Carpenter , intel-gfx@lists.freedesktop.org, Tomasz Figa , Monk Liu , linux-kernel@vger.kernel.org, Samuel Li , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Frediano Ziglio List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwNyBTZXAgMjAxNiwgTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEubWFzYWhpcm9Ac29j aW9uZXh0LmNvbT4gd3JvdGU6Cj4gUmVtb3ZlIHVubmVlZGVkIHZhcmlhYmxlcyBhbmQgYXNzaWdu bWVudHMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYXNhaGlybyBZYW1hZGEgPHlhbWFkYS5tYXNhaGly b0Bzb2Npb25leHQuY29tPgoKLi4uCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IDk1 ZGRkNTYuLjU5ZDAyOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtMTM2MSwx MyArMTM2MSw3IEBAIHZvaWQgaTkxNV9kcml2ZXJfdW5sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gIAo+ICBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX29wZW4oc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgc3RydWN0IGRybV9maWxlICpmaWxlKQo+ICB7Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCXJl dCA9IGk5MTVfZ2VtX29wZW4oZGV2LCBmaWxlKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJl dDsKPiAtCj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiBpOTE1X2dlbV9vcGVuKGRldiwgZmlsZSk7 Cj4gIH0KClNlZW1zIHRvIG1lIHRoZSB3aG9sZSBmdW5jdGlvbiBjb3VsZCBiZSByZXBsYWNlZCBi eSBhIGRpcmVjdCB1c2Ugb2YKaTkxNV9nZW1fb3BlbigpLgoKQlIsCkphbmkuCgoKLS0gCkphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbcIGIe4 (ORCPT ); Wed, 7 Sep 2016 04:34:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:48466 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbcIGIev (ORCPT ); Wed, 7 Sep 2016 04:34:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; d="scan'208";a="1052480415" From: Jani Nikula To: Masahiro Yamada , David Airlie , dri-devel@lists.freedesktop.org Cc: Masahiro Yamada , Gustavo Padovan , Yakir Yang , Huang Rui , Alex Deucher , Monk Liu , Chunming Zhou , Daniel Vetter , Heiko Stuebner , Eric Huang , Flora Cui , Inki Dae , Krzysztof Kozlowski , Dave Airlie , intel-gfx@lists.freedesktop.org, Frediano Ziglio , Samuel Li , Christian =?utf-8?Q?K=C3=B6nig?= , Tomasz Figa , Sumit Semwal , linux-kernel@vger.kernel.org, Tom St Denis , Dan Carpenter Subject: Re: [PATCH] drm: squash lines for simple wrapper functions In-Reply-To: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1473203062-21731-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 07 Sep 2016 11:34:44 +0300 Message-ID: <8760q8xg4b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Sep 2016, Masahiro Yamada wrote: > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada ... > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 95ddd56..59d029d 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1361,13 +1361,7 @@ void i915_driver_unload(struct drm_device *dev) > > static int i915_driver_open(struct drm_device *dev, struct drm_file *file) > { > - int ret; > - > - ret = i915_gem_open(dev, file); > - if (ret) > - return ret; > - > - return 0; > + return i915_gem_open(dev, file); > } Seems to me the whole function could be replaced by a direct use of i915_gem_open(). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center