From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Dave Anderson <anderson@redhat.com>
Cc: Masaki Tachibana <mas-tachibana@vf.jp.nec.com>,
Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
Minoru Usui <min-usui@ti.jp.nec.com>,
kexec@lists.infradead.org,
Daisuke Nishimura <dai-nishimura@rc.jp.nec.com>
Subject: Re: [PATCH] makedumpfile: support _count -> _refcount rename in struct page
Date: Thu, 16 Jun 2016 16:01:58 +0200 [thread overview]
Message-ID: <8760t9fd0p.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1366043437.15957172.1466084968204.JavaMail.zimbra@redhat.com> (Dave Anderson's message of "Thu, 16 Jun 2016 09:49:28 -0400 (EDT)")
Dave Anderson <anderson@redhat.com> writes:
> ----- Original Message -----
>> _count member was renamed to _refcount in linux commit commit 0139aa7b7fa12
>> ("mm: rename _count, field of the struct page, to _refcount") and this
>> broke makedumpfile. The reason for making the change was to find all users
>> accessing it directly and not through the recommended API. I tried
>> suggesting to revert the change but failed, I see no other choice than to
>> start supporting both _count and _refcount in makedumpfile.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> ---
>> - 'crash' tool is now broken as well.
>
> FYI, crash was fixed upstream a few weeks ago:
>
> commit 8ceb1ac628bf6a0a7f0bbfff030ec93081bca4cd
> Author: Dave Anderson <anderson@redhat.com>
> Date: Mon May 23 11:23:01 2016 -0400
>
> Fix for Linux commit 0139aa7b7fa12ceef095d99dc36606a5b10ab83a, which
> renamed the page._count member to page._refcount. Without the patch,
> certain "kmem" commands fail with the "kmem: invalid structure member
> offset: page_count".
> (anderson@redhat.com)
Missed that, thanks for the heads up!
--
Vitaly
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-06-16 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 13:33 [PATCH] makedumpfile: support _count -> _refcount rename in struct page Vitaly Kuznetsov
2016-06-16 13:49 ` Dave Anderson
2016-06-16 14:01 ` Vitaly Kuznetsov [this message]
2016-06-17 4:02 ` Atsushi Kumagai
2016-06-17 9:25 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760t9fd0p.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=anderson@redhat.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=dai-nishimura@rc.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=mas-tachibana@vf.jp.nec.com \
--cc=min-usui@ti.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.