From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1b881q-0003fL-DA
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 11:25:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1b881o-0007iM-EI
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 11:25:53 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1463632874-28559-1-git-send-email-eblake@redhat.com>
	<1463632874-28559-4-git-send-email-eblake@redhat.com>
Date: Wed, 01 Jun 2016 17:25:44 +0200
In-Reply-To: <1463632874-28559-4-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Wed, 18 May 2016 22:40:49 -0600")
Message-ID: <8760ttq6br.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 03/28] qemu-img: Don't leak errors when
 outputting JSON
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, "open list:Block layer core" <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>

Eric Blake <eblake@redhat.com> writes:

> If our JSON output ever encounters an error, we would just silently
> leak the local variable.  Instead, assert that our usage won't fail.

Suggest "leak the error object".  Can do on commit.

> Signed-off-by: Eric Blake <eblake@redhat.com>