From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1b7Lnn-00014X-OK
	for qemu-devel@nongnu.org; Mon, 30 May 2016 07:56:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1b7Lnl-0006u8-P0
	for qemu-devel@nongnu.org; Mon, 30 May 2016 07:56:10 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1463608420-26837-1-git-send-email-jsnow@redhat.com>
	<1463608420-26837-2-git-send-email-jsnow@redhat.com>
	<87vb283hw9.fsf@dusky.pond.sub.org>
	<b5a69ef7-81aa-89f1-cf3b-5cc9fdb03668@redhat.com>
Date: Mon, 30 May 2016 13:56:00 +0200
In-Reply-To: <b5a69ef7-81aa-89f1-cf3b-5cc9fdb03668@redhat.com> (John Snow's
	message of "Fri, 20 May 2016 17:27:02 -0400")
Message-ID: <8760tvep4f.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for
 qmp-eject
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com

John Snow <jsnow@redhat.com> writes:

> It already got applied, but I can change it to your preference. (Always
> return an -errno and an Error, delete-and-free when we don't care about
> it...)

I think that would be an improvement.  This is advice, not a demand :)