From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbcDGFCe (ORCPT ); Thu, 7 Apr 2016 01:02:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:59539 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbcDGFCd (ORCPT ); Thu, 7 Apr 2016 01:02:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="asc'?scan'208";a="953451152" From: Felipe Balbi To: Greg Kroah-Hartman Cc: Lu Baolu , Oliver Neukum , Mathias Nyman , Lee Jones , Heikki Krogerus , Chanwoo Choi , MyungJoo Ham , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux In-Reply-To: <20160407000719.GA25418@kroah.com> References: <1457423628-3183-1-git-send-email-baolu.lu@linux.intel.com> <1457423628-3183-4-git-send-email-baolu.lu@linux.intel.com> <1457613583.2411.11.camel@suse.com> <20160310235716.GB2586@kroah.com> <5704A59C.8040500@linux.intel.com> <20160406092950.GC29930@kroah.com> <87pou32g6f.fsf@intel.com> <20160407000719.GA25418@kroah.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Thu, 07 Apr 2016 08:00:35 +0300 Message-ID: <8760vu1098.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: >> > What happened to getting internal help in designing this api? This >> > shouldn't be my job :) >>=20 >> I looked at this Baolu but, at least to me, it's unclear what you're >> hinting here. Sure, the API is a bit odd in that we register a mux and >> unregister a device (that has been fixed), but is there anything else ? > > I don't remember anymore, that was a few thousand emails ago... > > But the suggestion about using devm_* shows that the original author > has very little understanding about how the driver model works at all, > which doesn't give me much hope at the moment... fair enough, that can also be 'fixed' with experience, right ? Just takes time ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXBel0AAoJEIaOsuA1yqREpuMP/2geXG9frDBhl9MRNb5Xfq8l b9gAhPqm+VHgCB+J2ma9Y2e2bzCJMTpFS0W7ZriLjarjIfTP1h22UKHu7OxsPuyl knbxDrpI/jW3AnzqSmuy23I4sI0YZqXBML++j/DIDHJIVmTNcktYOKp7ONyDX3Gk vKHdt+IGVYC3AKMBz15PkGzy6bb9kynfJrOJBLcTAh2OLa3B3ssZolEWaVO3ZI0g 0Uu/WMrYWNdVeUpfTd7gJFFu2RWNlzmZAMw0cWXTmk8NrQ2VeJHIYY7w5duZstc4 38sV/Hv1u8h4j5aOPziqeUCHo8RfD2XrTJjEIgC+jwZLKmY35jiRamy8Y+KkStqI mGaCE7ifbQo9cBJjrOvfRYB0HFy39UEhYVnmQpz7LiP8v9XQCS4k3aJXaTGv14Mj kcdZt6saxGkbRPI6AkTE3hOh9faSD86Y1aiWbtjyN+gnJgVFSP4bGAzUWECPAp9D pmuPhdm/epUx1irZF5bPDZaOWvt2kqfuU30L2CqkwBdoDxYomiaPMrsvQ9Qe2Vly FPFv+orUVOjm9+bXSqVUM4L2mzq0lb4sFpspluSIcMJX2nRqZ6xaXsWxq5VFWS2C N7KvsaUkomuDBWuuL5jENPPLBL4dzUOaCsSVXDqn3aVeUJyXhvy7JpPvqKHHvOtq YaX1WAv4hs+A/wCNgq1p =7/w4 -----END PGP SIGNATURE----- --=-=-=--