From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Rainer Weikusat <rweikusat@mobileactivedefense.com>,
davem@davemloft.net, hannes@stressinduktion.org,
edumazet@google.com, dhowells@redhat.com, ying.xue@windriver.com,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"stable\@vger.kernel.org" <stable@vger.kernel.org>,
Joseph Salisbury <joseph.salisbury@canonical.com>
Subject: Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code
Date: Sun, 07 Feb 2016 20:39:02 +0000 [thread overview]
Message-ID: <8760y0l0gp.fsf@doppelsaurus.mobileactivedefense.com> (raw)
In-Reply-To: <8737t4jr99.fsf@doppelsaurus.mobileactivedefense.com> (Rainer Weikusat's message of "Sun, 07 Feb 2016 18:43:14 +0000")
Rainer Weikusat <rw@doppelsaurus.mobileactivedefense.com> writes:
[...]
> the real problem is that the function disagrees with itself on how to
> use the err variable: The start uses that to record an error which
> might need to be reported, the return statement uses it to indicate
> that an error has occurred.
This should have been "as indication that an errors has occured" (if no
data was copied).
next prev parent reply other threads:[~2016-02-07 20:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:50 [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code Joseph Salisbury
2016-02-05 19:59 ` Rainer Weikusat
2016-02-05 20:06 ` Joseph Salisbury
2016-02-05 21:18 ` Rainer Weikusat
2016-02-05 22:04 ` Rainer Weikusat
2016-02-05 21:44 ` Rainer Weikusat
2016-02-05 23:03 ` Eric Dumazet
2016-02-07 18:43 ` Rainer Weikusat
2016-02-07 20:39 ` Rainer Weikusat [this message]
2016-02-07 22:24 ` Rainer Weikusat
2016-02-08 3:35 ` Eric Dumazet
2016-02-05 22:30 ` [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error Rainer Weikusat
2016-02-07 19:20 ` Rainer Weikusat
2016-02-08 15:33 ` Rainer Weikusat
2016-02-08 18:05 ` Rainer Weikusat
2016-02-08 18:47 ` Rainer Weikusat
2016-02-16 17:51 ` David Miller
2016-02-17 0:24 ` Ben Hutchings
2016-02-17 1:07 ` David Miller
2016-02-17 1:07 ` David Miller
2016-02-08 18:33 ` Sergei Shtylyov
2016-02-11 21:31 ` Joseph Salisbury
2016-02-12 13:31 ` Rainer Weikusat
2016-02-13 0:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760y0l0gp.fsf@doppelsaurus.mobileactivedefense.com \
--to=rweikusat@mobileactivedefense.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.