From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a9wca-0008Ui-9w
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:07:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a9wcX-0004AQ-33
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:07:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a9wcW-0004AK-Tl
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:07:01 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1449858642-24267-1-git-send-email-jjherne@linux.vnet.ibm.com>
	<87poy9rybu.fsf@blackfin.pond.sub.org>
	<566ED627.2030706@linux.vnet.ibm.com>
	<87mvtdnim6.fsf@blackfin.pond.sub.org>
	<5672F59B.7020907@linux.vnet.ibm.com>
	<87k2odszeo.fsf@blackfin.pond.sub.org>
Date: Fri, 18 Dec 2015 16:06:58 +0100
In-Reply-To: <87k2odszeo.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Thu, 17 Dec 2015 19:28:15 +0100")
Message-ID: <8760zvbxt9.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in
	error_report and other error functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org

Markus Armbruster <armbru@redhat.com> writes:

> "Jason J. Herne" <jjherne@linux.vnet.ibm.com> writes:
>
>> On 12/14/2015 10:40 AM, Markus Armbruster wrote:
>>> "Jason J. Herne" <jjherne@linux.vnet.ibm.com> writes:
>>>
>>>> On 12/14/2015 07:47 AM, Markus Armbruster wrote:
>>>>> "Jason J. Herne" <jjherne@linux.vnet.ibm.com> writes:
>>>>>
>>>>>> We don't want newlines embedded in error messages. This seems to
>>>>>> be a common
>>>>>> problem with new code so let's try to catch it with checkpatch.
>>>>>>
>>>>>> This will not catch cases where newlines are inserted into the
>>>>>> middle of an
>>>>>> existing multi-line statement. But those cases should be rare.
>>>>>>
>>>>>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>>>>>
>> ...
>>>> But I will take a look at this series and see if we can do better :).
>>>
>>> Thanks!  If we can't, then I'm for taking this imperfect patch, because
>>> flagging some of these mistakes is better than flagging none.
>>>
>>>
>>
>> I won't get a chance to get back to this before the new year. So feel
>> free to push this (unless someone objects) and I'll see what I can do
>> about improving it in January.
>
> Makes sense.  Applied to my local error-next branch.

With the warning changed from

    "Error function text should not contain newlines\n"

to

    "Error message string should not contain newlines\n"

[...]