All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
	Luigi Rizzo <rizzo@iet.unipi.it>
Subject: Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue
Date: Fri, 06 Nov 2015 11:06:37 +0100	[thread overview]
Message-ID: <87611fcuhe.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CA+_eA9jQ9hV+PjrZBmMuuupSFrN58qTPh0wwNgvzx_Wx=_UHzw@mail.gmail.com> (Vincenzo Maffione's message of "Thu, 5 Nov 2015 21:27:41 +0100")

Vincenzo Maffione <v.maffione@gmail.com> writes:

> 2015-11-05 16:01 GMT+01:00 Eric Blake <eblake@redhat.com>:
>> On 11/05/2015 07:52 AM, Vincenzo Maffione wrote:
>>> No worries.
>>>
>>> It needs --enable-netmap (default is --disable-netmap on linux), and
>>> --extra-cflags=-I/path/to/netmap/sys for netmap API headers.
>>>
>>> (netmap code is avaliable here https://github.com/luigirizzo/netmap)
>>
>> Default-off tends to bit-rot; default-probe is slightly better (compile
>> if /path/to/netmap/sys is found during configure, otherwise not).  But
>> not the end of the world.
>
> The default-off decision was taken at the time when netmap was merged
> in (see the
> "[PATCH v3] net: Adding netmap network backend" thread).
> The qemu ./configure already has support for probing netmap headers,
> so we could actually switch to default-on also on linux (like it
> happens for freebsd qemu build).
>
> Thanks for the pointer to the headers. Any
>> idea if someone is trying to package netmap development headers for Fedora?
>
> No idea, unfortunately. I personally maintain an AUR package for
> Archlinux (https://aur.archlinux.org/packages/netmap/), that's all I
> know. Having netmap headers packaged in some distributions is
> something we were willing to do, but still nothing has been done,
> afaik.

As long as netmap isn't packaged in at least one distro we actually
compile-test before merge into master, enabling it automatically won't
do squat for avoiding bitrot.

  reply	other threads:[~2015-11-06 10:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  9:35 [Qemu-devel] [PATCH 0/2] Fix compilation of netmap backend Vincenzo Maffione
2015-11-05  9:35 ` [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue Vincenzo Maffione
2015-11-05 13:01   ` Markus Armbruster
2015-11-05 13:26     ` Vincenzo Maffione
2015-11-05 14:46     ` Eric Blake
2015-11-05 14:52       ` Vincenzo Maffione
2015-11-05 15:01         ` Eric Blake
2015-11-05 20:27           ` Vincenzo Maffione
2015-11-06 10:06             ` Markus Armbruster [this message]
2015-11-05  9:35 ` [Qemu-devel] [PATCH 2/2] net: netmap: use error_setg_errno() in place of error_report() Vincenzo Maffione
2015-11-05 13:13   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87611fcuhe.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=stefanha@redhat.com \
    --cc=v.maffione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.