From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: fix mutex leak in drm_dp_get_mst_branch_device Date: Mon, 19 Oct 2015 11:14:44 +0300 Message-ID: <8761231dhn.fsf@intel.com> References: <20151016172416.GL13786@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A60D76E2D9 for ; Mon, 19 Oct 2015 01:11:15 -0700 (PDT) In-Reply-To: <20151016172416.GL13786@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Adam Richter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxNiBPY3QgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBGcmksIE9jdCAxNiwgMjAxNSBhdCAwMzozMzowMkFNIC0wNzAwLCBBZGFtIFJpY2h0 ZXIgd3JvdGU6Cj4+IEluIExpbnV4IDQuMy1yYzUsIHRoZXJlIGlzIGFuIGVycm9yIGNhc2UgaW4g ZHJtX2RwX2dldF9icmFuY2hfZGV2aWNlCj4+IHRoYXQgcmV0dXJucyB3aXRob3V0IHJlbGVhc2lu ZyBtZ3ItPmxvY2ssIHJlc3VsdGluZyBhIHNwZXcgb2Yga2VybmVsCj4+IG1lc3NhZ2VzIGFib3V0 IGEga2VybmVsIHdvcmsgZnVuY3Rpb24gcG9zc2libHkgaGF2aW5nIGxlYWtlZCBhIG11dGV4Cj4+ IGFuZCBwcmVzdW1hYmx5IG1vcmUgc2VyaW91cyBhZHZlcnNlIGNvbnNlcXVlbmNlcyBsYXRlci4g IFRoaXMgcGF0Y2gKPj4gY2hhbmdlcyB0aGUgZXJyb3IgdG8gImdvdG8gb3V0IiB0byB1bmxvY2sg dGhlIG11dGV4IGJlZm9yZSByZXR1cm5pbmcuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBBZGFtIEou IFJpY2h0ZXIgPGFkYW1fcmljaHRlcjIwMDRAeWFob28uY29tPgo+Cj4gUGF0Y2ggd2FzIHdoaXRl c3BhY2UgbWFuZ2xlZCAoZG9uJ3QgcGFzdCB0aGVtIGludG8geW91ciBtYWlsZXIgYnV0IGluc3Rl YWQKPiBzZW5kIHRoZW0gd2l0aCBnaXQgc2VuZC1lbWFpbCBkaXJlY3RseSwgdGhhdCdzIHNhZmVy KSwgc28gSSBoYWQgdG8KPiByZWNyZWF0ZSBpdC4KPgo+IEFwcGxpZWQgdG8gZHJtLW1pc2MsIHRo YW5rcy4KCkl0J3MgbWlzc2luZwoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+CkJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3df YnVnLmNnaT9pZD05MjQ4MApGaXhlczogOWViMWU1N2Y1NjRkICgiZHJtL2RwL21zdDogdGFrZSBs b2NrIGFyb3VuZCBsb29raW5nIHVwIHRoZSBicmFuY2ggZGV2aWNlIG9uIGhwZCBpcnEiKQpDYzog c3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHY0LjIrCgphbmQgYXJndWFibHkgd2FzIGZvciBkcm0t Zml4ZXMuCgpCUiwKSmFuaS4KCgoKPiAtRGFuaWVsCj4KPj4gLS0tCj4+IAo+PiBidWd6aWxsYS5m cmVlZGVza3RvcC5vcmcgdGlja2V0Ogo+PiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3No b3dfYnVnLmNnaT9pZD05MjQ4MAo+PiAKPj4gVGhpcyBwYXRjaCBpcyBhZ2FpbnN0IHRoZSBsYXRl c3QKPj4gZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZh bGRzL2xpbnV4LmdpdCAuICBJCj4+IGFwb2xvZ2l6ZSBpbiBhZHZhbmNlIGluIEkgc2hvdWxkIGJl IHN1Ym1pdHRpbmcgcGF0Y2hlcyBhZ2FpbnN0IHNvbWUKPj4gb3RoZXIgcmVmZXJlbmNlLiAgUGxl YXNlIGZlZWwgZnJlZSB0byBsZXQgbWUga25vdyBpZiBJIHNob3VsZCB1c2Ugc29tZQo+PiBvdGhl ciByZWZlcmVuY2UgZm9yIHN1Ym1pdHRpbmcgZnV0dXJlIHBhdGNoZXMuCj4+IAo+PiBNeSByZXF1 ZXN0IHRvIHN1YnNjcmliZSB0byBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIGlzIHBl bmRpbmcsCj4+IHNvIEkgYXBvbG9naXplIGlmIGl0IHRha2VzIGEgd2hpbGUgZm9yIHRoaXMgbWVz c2FnZSB0byBiZSBwb3N0ZWQgb24KPj4gdGhlIG1haWxpbmcgbGlzdC4KPj4gCj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4+IGIvZHJpdmVycy9n cHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+PiBpbmRleCBiZjI3YTA3Li4wMThhZDdmIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMKPj4gQEAgLTExOTQsMTcg KzExOTQsMTggQEAgc3RhdGljIHN0cnVjdCBkcm1fZHBfbXN0X2JyYW5jaAo+PiAqZHJtX2RwX2dl dF9tc3RfYnJhbmNoX2RldmljZShzdHJ1Y3QgZHJtX2RwX21zdF8KPj4gCj4+ICAgICAgICAgICAg ICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHBvcnQsICZtc3RiLT5wb3J0cywgbmV4dCkgewo+PiAg ICAgICAgICAgICAgICAgICAgICAgICBpZiAocG9ydC0+cG9ydF9udW0gPT0gcG9ydF9udW0pIHsK Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIXBvcnQtPm1zdGIpIHsKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtc3RiID0gcG9ydC0+bXN0YjsKPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIW1zdGIpIHsKPj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiZmFpbGVkIHRvIGxvb2t1cAo+ PiBNU1RCIHdpdGggbGN0ICVkLCByYWQgJTAyeFxuIiwgbGN0LCByYWRbMF0pOwo+PiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB9Cj4+IAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG1zdGIgPSBwb3J0LT5tc3RiOwo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwo+PiAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4+ICAgICAgICAgICAgICAgICB9 Cj4+ICAgICAgICAgfQo+PiAgICAgICAgIGtyZWZfZ2V0KCZtc3RiLT5rcmVmKTsKPj4gKyBvdXQ6 Cj4+ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZtZ3ItPmxvY2spOwo+PiAgICAgICAgIHJldHVybiBt c3RiOwo+PiAgfQo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo+Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK