From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmeEw-0001ev-AG for qemu-devel@nongnu.org; Thu, 15 Oct 2015 04:50:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmeEr-0007f8-U5 for qemu-devel@nongnu.org; Thu, 15 Oct 2015 04:50:22 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:48149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmeEr-0007cw-LW for qemu-devel@nongnu.org; Thu, 15 Oct 2015 04:50:17 -0400 From: OGAWA Hirofumi References: <87k2qp8yxv.fsf@mail.parknet.co.jp> <87fv1d8ywp.fsf@mail.parknet.co.jp> <87bnc18yvw.fsf_-_@mail.parknet.co.jp> <1444837495.4467.29.camel@redhat.com> <87y4f56lzu.fsf@mail.parknet.co.jp> <1444895333.24283.7.camel@redhat.com> <87a8rk7d5q.fsf@mail.parknet.co.jp> Date: Thu, 15 Oct 2015 17:50:12 +0900 In-Reply-To: <87a8rk7d5q.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Thu, 15 Oct 2015 17:24:01 +0900") Message-ID: <8761287by3.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org OGAWA Hirofumi writes: >> Ok, curses and gtk can't be active at the same time. But for curses and >> vnc it is possible (qemu -curses -vnc :$display), and you probably get a >> dissorted vga text mode over vnc then. >> >> I think the mapping should happen in the curses code, when curses >> updates the screen. curses_update() function is probably the best place >> for it. > > OK. It would be possible though, but parsing at curses_update() is > slower. It is why, I did at that. Well, I'll see. I've checked callers and usage of console_write_ch(). Call path is following paths. curses_refresh() graphic_hw_text_update(NULL, screen); ->text_update() vga_update_text() console_write_ch() ->text_update() jazz_led_text_update() console_write_ch() ->text_update() text_console_update() console_write_ch() >>From this call paths, graphic_hw_text_update() => console_write_ch() => ->text_update() path is only used for -curses mode. What do you think? (E.g. qemu is going to extend to use this for other purpose?) I guess, rather qemu wants to remove the call of ->text_update() for micro optimization if curses display is not used. (I'm not sure how optimizes it right now though.) Thanks. -- OGAWA Hirofumi