From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZZdRu-0005hq-RS
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 07:21:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZZdRu-0005fm-0v
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 07:21:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49128)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZZdRt-0005fW-Sn
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 07:21:57 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1441732357-11861-3-git-send-email-jjherne@linux.vnet.ibm.com>
	(Jason J. Herne's message of "Tue, 8 Sep 2015 13:12:34 -0400")
References: <1441732357-11861-1-git-send-email-jjherne@linux.vnet.ibm.com>
	<1441732357-11861-3-git-send-email-jjherne@linux.vnet.ibm.com>
Date: Wed, 09 Sep 2015 13:21:54 +0200
Message-ID: <87613j6dnx.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v7 2/5] migration: Parameters for
	auto-converge cpu throttling
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, borntraeger@de.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de

"Jason J. Herne" <jjherne@linux.vnet.ibm.com> wrote:

> @@ -344,6 +359,18 @@ void qmp_migrate_set_parameters(bool has_compress_level,
>                    "is invalid, it should be in the range of 1 to 255");
>          return;
>      }
> +    if (has_x_cpu_throttle_initial &&
> +            (x_cpu_throttle_initial < 1 || x_cpu_throttle_initial > 99)) {
> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> +                  "x_cpu_throttle_initial",
> +                  "an integer in the range of 1 to 99");
> +    }
> +    if (has_x_cpu_throttle_increment &&
> +            (x_cpu_throttle_increment < 1 || x_cpu_throttle_increment > 99)) {
> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> +                  "x_cpu_throttle_increment",
> +                  "an integer in the range of 1 to 99");
> +    }

s/error_set/error_setg/

the same than the rest of the file, and without that change it don't
even compile against Today master.

Done by me, no need to do anything.

Later, Juan.