From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4nvc-0006MX-Dj for ath10k@lists.infradead.org; Tue, 16 Jun 2015 10:17:13 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: txrx: remove unreachable negative return check and fixup type References: <1434039489-24934-1-git-send-email-hofrat@osadl.org> Date: Tue, 16 Jun 2015 13:16:23 +0300 In-Reply-To: <1434039489-24934-1-git-send-email-hofrat@osadl.org> (Nicholas Mc Guire's message of "Thu, 11 Jun 2015 18:18:09 +0200") Message-ID: <87616o7ybs.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Nicholas Mc Guire Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org Nicholas Mc Guire writes: > wait_event_timeout(), introduced in 'commit 5e3dd157d7e7 ("ath10k: mac80211 > driver for Qualcomm Atheros 802.11ac CQA98xx devices")' never returns < 0 > so the only failure condition to be checked is == 0 (timeout). Further the > return type is long not int - an appropriately named variable is added > and the assignments fixed up. > > Signed-off-by: Nicholas Mc Guire Thanks, applied. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:3737 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756455AbbFPKQ3 (ORCPT ); Tue, 16 Jun 2015 06:16:29 -0400 From: Kalle Valo To: Nicholas Mc Guire CC: , , , Subject: Re: [PATCH] ath10k: txrx: remove unreachable negative return check and fixup type References: <1434039489-24934-1-git-send-email-hofrat@osadl.org> Date: Tue, 16 Jun 2015 13:16:23 +0300 In-Reply-To: <1434039489-24934-1-git-send-email-hofrat@osadl.org> (Nicholas Mc Guire's message of "Thu, 11 Jun 2015 18:18:09 +0200") Message-ID: <87616o7ybs.fsf@kamboji.qca.qualcomm.com> (sfid-20150616_121653_751791_5F1D7135) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Nicholas Mc Guire writes: > wait_event_timeout(), introduced in 'commit 5e3dd157d7e7 ("ath10k: mac80211 > driver for Qualcomm Atheros 802.11ac CQA98xx devices")' never returns < 0 > so the only failure condition to be checked is == 0 (timeout). Further the > return type is long not int - an appropriately named variable is added > and the assignments fixed up. > > Signed-off-by: Nicholas Mc Guire Thanks, applied. -- Kalle Valo