From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMxU-0002ns-Jp for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:48:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMxQ-00015O-J2 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:48:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMxQ-00015J-Au for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:48:12 -0500 From: Markus Armbruster References: <1423722111-12902-1-git-send-email-eric.fangyi@huawei.com> <54F3BC0A.4010209@huawei.com> Date: Mon, 02 Mar 2015 10:48:05 +0100 In-Reply-To: <54F3BC0A.4010209@huawei.com> (Fangyi's message of "Mon, 2 Mar 2015 09:25:30 +0800") Message-ID: <8761ajivca.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Fangyi (C)" Cc: famz@redhat.com, stefanha@redhat.com, kathy.wangting@huawei.com, "qemu-devel@nongnu.org" , boby.chen@huawei.com, Paolo Bonzini , rudy.zhangmin@huawei.com, wu.wubin@huawei.com "Fangyi (C)" writes: > PING Please drop this line, it doesn't belong to the commit message. You copied a bunch of people, but forgot the maintainer: $ scripts/get_maintainer.pl -f nbd.c Paolo Bonzini (odd fixer:Network Block Dev...) I fixed that for you. > The value of reply.error should be the type unsigned int. > > Signed-off-by: Yik Fang > --- > nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/nbd.c b/nbd.c > index e56afbc1..30e2f3b 100644 > --- a/nbd.c > +++ b/nbd.c > @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque) > default: > LOG("invalid request type (%u) received", request.type); > invalid_request: > - reply.error = -EINVAL; > + reply.error = EINVAL; > error_reply: > if (nbd_co_send_reply(req, &reply, 0) < 0) { > goto out; > -- 1.8.5