From: Andi Kleen <andi@firstfloor.org>
To: Josef Bacik <jbacik@fb.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
<linux-fsdevel@vger.kernel.org>, <viro@ZenIV.linux.org.uk>,
<hch@infradead.org>, <clm@fb.com>
Subject: Re: Name hashing function causing a perf regression
Date: Fri, 12 Sep 2014 12:11:06 -0700 [thread overview]
Message-ID: <8761gs64dx.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <540F5562.1050505@fb.com> (Josef Bacik's message of "Tue, 9 Sep 2014 15:30:42 -0400")
Josef Bacik <jbacik@fb.com> writes:
>
> So the question is what do we do here? I tested other random strings
> and every one of them ended up worse as far as collisions go with the
> new function vs the old one. I assume we want to keep the word at a
> time functionality, so should we switch to a different hashing scheme,
> like murmur3/fnv/xxhash/crc32c/whatever? Or should we just go back to
Would be interesting to try murmur3.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2014-09-12 19:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 19:30 Name hashing function causing a perf regression Josef Bacik
2014-09-12 19:11 ` Andi Kleen [this message]
2014-09-12 19:21 ` Linus Torvalds
2014-09-12 19:52 ` Josef Bacik
2014-09-12 20:39 ` Linus Torvalds
2014-09-12 21:25 ` Josef Bacik
2014-09-12 22:01 ` Linus Torvalds
2014-09-12 22:08 ` Josef Bacik
2014-09-12 22:25 ` Linus Torvalds
2014-09-13 18:58 ` Linus Torvalds
2014-09-15 1:32 ` Linus Torvalds
2014-09-15 2:49 ` Tetsuo Handa
2014-09-15 3:37 ` Linus Torvalds
2014-09-15 4:58 ` Tetsuo Handa
2014-09-15 14:17 ` Linus Torvalds
2014-09-15 15:55 ` Josef Bacik
2014-09-15 16:22 ` Linus Torvalds
2014-09-15 16:25 ` Al Viro
2014-09-15 16:33 ` Linus Torvalds
2014-09-15 16:35 ` Greg KH
2014-09-15 16:45 ` Linus Torvalds
2014-09-15 16:53 ` Jiri Slaby
2014-09-15 17:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761gs64dx.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=clm@fb.com \
--cc=hch@infradead.org \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.