From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XMFBj-0002v3-7D
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:45:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XMFBe-00062Z-E0
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:45:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XMFBe-00062V-4U
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:45:18 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1408956257-8176-1-git-send-email-john.liuli@huawei.com>
Date: Tue, 26 Aug 2014 13:44:34 +0200
In-Reply-To: <1408956257-8176-1-git-send-email-john.liuli@huawei.com> (john
	liuli's message of "Mon, 25 Aug 2014 16:44:17 +0800")
Message-ID: <8761hfa319.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree
	err message to stderr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "john.liuli" <john.liuli@huawei.com>
Cc: peter.crosthwaite@xilinx.com, agraf@suse.de, qemu-devel@nongnu.org

"john.liuli" <john.liuli@huawei.com> writes:

> From: Li Liu <john.liuli@huawei.com>
>
> Signed-off-by: Li Liu <john.liuli@huawei.com>
> ---
>  device_tree.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index ca83504..ccdb039 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -79,7 +79,7 @@ void *load_device_tree(const char *filename_path, int *sizep)
>      *sizep = 0;
>      dt_size = get_image_size(filename_path);
>      if (dt_size < 0) {
> -        printf("Unable to get size of device tree file '%s'\n",
> +        fprintf(stderr, "Unable to get size of device tree file '%s'\n",
>              filename_path);
>          goto fail;
>      }
> @@ -92,20 +92,20 @@ void *load_device_tree(const char *filename_path, int *sizep)
>  
>      dt_file_load_size = load_image(filename_path, fdt);
>      if (dt_file_load_size < 0) {
> -        printf("Unable to open device tree file '%s'\n",
> +        fprintf(stderr, "Unable to open device tree file '%s'\n",
>                 filename_path);
>          goto fail;
>      }
>  
>      ret = fdt_open_into(fdt, fdt, dt_size);
>      if (ret) {
> -        printf("Unable to copy device tree in memory\n");
> +        fprintf(stderr, "Unable to copy device tree in memory\n");
>          goto fail;
>      }
>  
>      /* Check sanity of device tree */
>      if (fdt_check_header(fdt)) {
> -        printf ("Device tree file loaded into memory is invalid: %s\n",
> +        fprintf(stderr, "Device tree file loaded into memory is invalid: %s\n",
>              filename_path);
>          goto fail;
>      }

A welcome improvement.  Further improvement would be using
error_report().