From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions
Date: Fri, 25 Jul 2014 11:15:12 +0100 [thread overview]
Message-ID: <8761ilhhg6.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_e8JvxfMzFKkSc6m4nQV__b74rM36Qk97oNr0-fyY96w@mail.gmail.com>
Peter Maydell writes:
> On 24 July 2014 16:52, Alex Bennée <alex.bennee@linaro.org> wrote:
>> +/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions
>> + * Page D4-1736 (DDI0487A.b) "For TLB maintenance instructions that
>> + * take an address, the maintenance of VA[63:56] is interpreted as
>> + * being the same as the maintenance of VA[55]"
>> + */
>
> I'd rather we didn't quote this bit of the ARM ARM, because it's
> obviously mangled (I'm pretty sure it should say "the value of
> VA[..]").
Is it OK to still reference the ARM ARM because otherwise the sign
extension would look a little weird without context (although obviously
we have a commit message to say we fixed something).
>
> Otherwise
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2014-07-25 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 15:52 [Qemu-devel] [RFC PATCH 0/3] target-arm: Some fixes to page and TLB handling Alex Bennée
2014-07-24 15:52 ` [Qemu-devel] [PATCH 1/3] target-arm: don't hardcode mask values in arm_cpu_handle_mmu_fault Alex Bennée
2014-07-24 16:10 ` Peter Maydell
2014-07-24 15:52 ` [Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions Alex Bennée
2014-07-24 16:09 ` Peter Maydell
2014-07-25 10:15 ` Alex Bennée [this message]
2014-07-24 15:52 ` [Qemu-devel] [PATCH 3/3] target-arm: A64: fix use 12 bit page tables for aarch64 Alex Bennée
2014-07-24 16:12 ` Peter Maydell
2014-07-24 16:15 ` [Qemu-devel] [RFC PATCH 0/3] target-arm: Some fixes to page and TLB handling Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ilhhg6.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.