Re: [Qemu-devel] [PATCH v2 1/8] enable sharing of the function between migration and bitmap dump

[Juan Quintela <quintela@redhat.com>]

Sanidhya Kashyap <sanidhya.iiith@gmail.com> wrote:
> As advised by Eric, I have enabled sharing of the function between of the
> function that syncs the dirty bitmap obtained via kvm ioctl. I have tried
> to make the least changes to the functions by concentrating only on the
> function definitions.
>
> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
> ---
>  arch_init.c             | 19 +++++++++++--------
>  include/exec/ram_addr.h |  4 ++++
>  2 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 685ba0e..48eb90a 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -434,20 +434,22 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr,
>      return (next - base) << TARGET_PAGE_BITS;
>  }
>  
> -static inline bool migration_bitmap_set_dirty(ram_addr_t addr)
> +static inline bool bitmap_set_dirty(ram_addr_t addr, unsigned long *bitmap,
> +                                                     bool migration_flag)

Exporting a function without a prefix could be dangerous.

Later, Juan.